Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating SDK version #44734

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Updating SDK version #44734

merged 2 commits into from
Oct 26, 2022

Conversation

brunolins16
Copy link
Member

@brunolins16 brunolins16 commented Oct 25, 2022 •
edited
Loading

Adding #44601 back and including the workaround described at NuGet/Home#12159 (comment)

cc @rainersigwald @nkolev92 @kartheekp-ms

MackinnonBuck and others added 2 commits October 25, 2022 14:42
@MackinnonBuck @sebastienros @brunolins16
Update SDK (dotnet#44601)
d0d8803 
* Update SDK

* Update global.json

* Trying previous version

* Update global.json

* Updating 8.0.100-alpha.1.22524

* Updating MicrosoftNetCompilersToolsetVersion to 4.5.0-1.22517.9

* Fix CA1507

* Removing EnableAltSvc

Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
Co-authored-by: Bruno Oliveira <brunolins16@users.noreply.github.com>
Co-authored-by: Bruno Oliveira <brolivei@microsoft.com>
@brunolins16
Adding nuget --version workaround
43adc34
@brunolins16 brunolins16 marked this pull request as ready for review October 25, 2022 21:48
dougbu
dougbu approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@build-analysis build-analysis bot mentioned this pull request Oct 26, 2022
Closed
2 tasks
@brunolins16 brunolins16 merged commit 68fcc9c into dotnet:main Oct 26, 2022
@ghost ghost added this to the 8.0-preview1 milestone Oct 26, 2022
@brunolins16 brunolins16 mentioned this pull request Oct 26, 2022
Closed
@wtgodbe wtgodbe mentioned this pull request Nov 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0-preview1
Development

Successfully merging this pull request may close these issues.
4 participants
@brunolins16 @dougbu @wtgodbe @MackinnonBuck