Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable setting ServerTimeout and KeepAliveInterval in HubConnectionBuilder #46065

Merged
merged 15 commits into from
Jan 19, 2023

Conversation

surayya-MS
Copy link
Member

@surayya-MS surayya-MS commented Jan 12, 2023

Enable setting ServerTimeout and KeepAliveInterval in HubConnectionBuilder

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Added withServerTimeout and withKeepAliveInterval in HubConnectionBuilder for ts and csharp clients

Fixes #18840 and partially #44742

@ghost ghost added the area-signalr Includes: SignalR clients and servers label Jan 12, 2023
surayya-MS and others added 6 commits January 17, 2023 19:49
…s.cs

Co-authored-by: Brennan <brecon@microsoft.com>
Co-authored-by: Brennan <brecon@microsoft.com>
Co-authored-by: Brennan <brecon@microsoft.com>
…rExtensions.cs

Co-authored-by: Brennan <brecon@microsoft.com>
…ubConnection

2. Added test to HubConnectionBuilderTests
surayya-MS and others added 2 commits January 18, 2023 18:44
Co-authored-by: Brennan <brecon@microsoft.com>
Co-authored-by: Brennan <brecon@microsoft.com>
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to do the same thing in HttpHubConnectionBuilder.java? If we do, it doesn't have to be in this PR.

src/SignalR/clients/ts/signalr/src/HubConnection.ts Outdated Show resolved Hide resolved
@surayya-MS
Copy link
Member Author

Do we want to do the same thing in HttpHubConnectionBuilder.java? If we do, it doesn't have to be in this PR.

Yes. It will be in another PR.

@surayya-MS surayya-MS enabled auto-merge (squash) January 19, 2023 12:19
@surayya-MS surayya-MS merged commit fdf79c0 into dotnet:main Jan 19, 2023
@ghost ghost added this to the 8.0-preview1 milestone Jan 19, 2023
@surayya-MS surayya-MS deleted the hubConnectionBuilder branch February 23, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customizable serverTimeoutInMilliseconds in Server-Side Blazor
3 participants