Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Source-build: Allow setting KnownAppHostPack and KnownRuntimePack #46735

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

ayakael
Copy link

@ayakael ayakael commented Feb 18, 2023

##Source-build: Allow setting KnownAppHostPack and KnownRuntimePack

Description

This should've been in #44752, which was backport of #43937. Without this, we run into unrecognized RID issues in source-build application.

Customer impact

Will be able to build aspnetcore with RIDs that were automatically added in the runtime graph when building with source-build.

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

Only activates when PortableBuild=false. As it defaults to true, this change should not affect any other customers than distro maintainers.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@ayakael ayakael requested a review from a team as a code owner February 18, 2023 00:26
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member labels Feb 18, 2023
@ghost
Copy link

ghost commented Feb 18, 2023

Thanks for your PR, @ayakael. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@ghost ghost added this to the 6.0.x milestone Feb 18, 2023
@ghost
Copy link

ghost commented Feb 18, 2023

Hi @ayakael. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me but I don't think the branches are open. @mmitche, @vseanreesermsft

@dougbu
Copy link
Member

dougbu commented Feb 20, 2023

This won't succeed for a while. Is the fix urgent❔

@ayakael
Copy link
Author

ayakael commented Feb 20, 2023

This won't succeed for a while. Is the fix urgentgrey_question

Not at all. We already deploy this fix in the Alpine Linux dotnet6 package so the runtime graph gets automatically updated on new releases. I'm upstreaming this as a courtesy.

@ghost
Copy link

ghost commented Feb 28, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please leave an /azp run comment here to rerun the CI pipeline and confirm success before merging the change.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 28, 2023
@mkArtakMSFT mkArtakMSFT assigned wtgodbe and unassigned dougbu Mar 10, 2023
@wtgodbe
Copy link
Member

wtgodbe commented Mar 10, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@wtgodbe wtgodbe merged commit 73447ee into dotnet:release/6.0 Mar 10, 2023
@ghost ghost modified the milestones: 6.0.x, 6.0.16 Mar 10, 2023
@wtgodbe wtgodbe added tell-mode Indicates a PR which is being merged during tell-mode and removed pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun labels Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants