Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup HybridCache public API #55732

Merged
merged 1 commit into from
May 16, 2024
Merged

Fixup HybridCache public API #55732

merged 1 commit into from
May 16, 2024

Conversation

mgravell
Copy link
Member

@mgravell mgravell commented May 15, 2024 •
edited
Loading

Fixup HybridCache public API

  1. apply approved API changes per HybridCache - rename RemoveKeyAsync and RemoveTagAsync to "By" #55332
  2. fix incorrect namespace of service extension types to the standard DI dumping ground (as per the previously approved API, Hybrid Cache API proposal #54647)
  3. fix misapplication of serializer APIs; approved naming was AddSerializer, not WithSerializer (in Hybrid Cache API proposal #54647)

/cc @amcasey

@mgravell
1. apply API changes per #55332
e1155e0 
2. fix incorrect namespace of service extension types
@mgravell mgravell added the feature-caching Includes: StackExchangeRedis and SqlServer distributed caches label May 15, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label May 15, 2024
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels May 15, 2024
@mgravell mgravell merged commit 82b0fc9 into main May 16, 2024
26 checks passed
@mgravell mgravell deleted the marc/hc-fixup branch May 16, 2024 09:17
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview5 milestone May 16, 2024
@BrennanConroy BrennanConroy mentioned this pull request Aug 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcasey amcasey amcasey approved these changes

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-caching Includes: StackExchangeRedis and SqlServer distributed caches
Projects
None yet
Milestone
9.0-preview5
Development

Successfully merging this pull request may close these issues.
2 participants
@mgravell @amcasey