Update branding to 10.0 #57340
Merged
Update branding to 10.0 #57340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-infrastructure
wtgodbe
requested review from
JamesNK,
captainsafia and
mgravell
as code owners
JamesNK
reviewed
Aug 15, 2024
| @@ -6,6 +6,7 @@ | |||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | |||
| <TieredCompilation>false</TieredCompilation> | |||
| <DefineConstants>$(DefineConstants);IS_BENCHMARKS</DefineConstants> | |||
| <SkipMicrobenchmarksValidation>true</SkipMicrobenchmarksValidation> | |||
There was a problem hiding this comment.
The microbenchmark fails to find the just built SharedFx - this happens every time we update the branding/TFM in certain microbenchmarks, we're able to re-enable it once we get an SDK with the new TFM
JamesNK
approved these changes
Aug 15, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.