Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringBuilderPool
, it's a performance anti-pattern in case of S.CL because it was almost always used only once per process lifetime. We were paying for the pool creation but not taking any benefits from having it.RegisterWithDotnetSuggest
, it's too expensive to start a new process for every app by default (even just once)For now those who want to use
dotnet-suggest
they need to simply register their apps in explicit way by calling a dedicated command for that:This should be done as part of the app installation.
In the future we are most likely going to improve this process, but we need to have a discussion with @jonsequitur and @SteveL-MSFT about it.
cc @MichalStrehovsky who "loved" this feature and "promoted" in on Twitter multiple times