This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
JIT: Use AllocObj for box allocations #13988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Model box object allocations using the AllocObj tree node. Update the box deconstruction utility to compensate. Also set the OMF_HAS_NEWOBJ flag when we generate Box IR; this both fixes an oversight from before and is a necessary step to trigger the morphing of AllocObj into a helper call. No diffs. Closes #13905.
|
@erozenfeld PTAL No diffs. |
|
More apparent flakiness in test legs. @dotnet-bot retest Ubuntu x64 Formatting |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model box object allocations using the AllocObj tree node. Update
the box deconstruction utility to compensate.
Also set the OMF_HAS_NEWOBJ flag when we generate Box IR; this both
fixes an oversight from before and is a necessary step to trigger the
morphing of AllocObj into a helper call.
No diffs.
Closes #13905.