Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Enable building of Ubuntu/arm crossarch components in netci #17375

Merged
merged 1 commit into from
Apr 14, 2018

Conversation

echesakov
Copy link

@echesakov echesakov commented Mar 31, 2018

@BruceForstall Do you think it's safe now to enable building crosscomponents for Ubuntu arm (which automatically enables R2R crossgen-ing of S.P.C.dll before tests running)? FYI, I rebased dev/unit_test_workflow to include #17342 changes.

#17274 Innerloop is green and just one pri1 test failed during Normal (Loader/binding/assemblies/assemblybugs/177066w/repro177066/repro177066.sh).

/cc @RussKeldorph

@jashook
Copy link

jashook commented Apr 1, 2018

@echesakovMSFT the failures seem interesting. Also @BruceForstall the build timed out running the tests is this change slowing down test runs, or do these jobs run at the timeout threshold normally.

@jashook
Copy link

jashook commented Apr 1, 2018

On a second look through it looks like there may be a bug? The test run seems to spend a 3+ hours on something.

13:58:42          - JIT/superpmi/superpmicollect/superpmicollect.sh
16:59:05 
Build timed out (after 240 minutes). Marking the build as aborted.
16:59:05 
Build was aborted
16:59:05 [Current build status] check if current [ABORTED] is worse or equals then [SUCCESS] and better or equals then [SUCCESS]
16:59:05 Run condition [Current build status] preventing perform for step [[Archive the artifacts]]
16:59:05 [xUnit] [INFO] - Starting to record.
16:59:05 [xUnit] [INFO] - Processing xUnit.Net-v2 (default)
16:59:06 FAILED   - Interop/ArrayMarshalling/ByValArray/MarshalArrayByValTest/MarshalArrayByValTest.sh
16:59:06      

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine to me IF the tests all pass.

Currently, though, it looks like the tests DON'T all pass. It's worrisome that repro177066.sh fails 20 times in a row. At a minimum, we would need to disable this test and open an issue to track. There are quite a few other tests that fail many times but not every time. That's worrisome, but that's pretty common unfortunately right now.

@BruceForstall
Copy link
Member

@jashook what job are you looking at? The clip you show makes it look like the superpmicollect test is hanging.

@jashook
Copy link

jashook commented Apr 3, 2018

I was under the impression that these tests only echo after finishing, I may be reading runtests.sh wrong. Either way, you can see the log here: https://ci.dot.net/job/dotnet_coreclr/job/master/job/arm_cross_checked_ubuntu_innerloop_tst_prtest/199/console

@BruceForstall
Copy link
Member

I was under the impression that these tests only echo after finishing

Ah, right.

@echesakov echesakov added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 5, 2018
@echesakov echesakov changed the title Enable building of Ubuntu/arm crossarch components in netci [WIP] Enable building of Ubuntu/arm crossarch components in netci Apr 5, 2018
@echesakov echesakov force-pushed the dev/unix_test_workflow branch 2 times, most recently from c19b7a2 to 2035e8c Compare April 12, 2018 19:45
@RussKeldorph RussKeldorph added this to the 2.1.0 milestone Apr 13, 2018
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@echesakov echesakov changed the title [WIP] Enable building of Ubuntu/arm crossarch components in netci Enable building of Ubuntu/arm crossarch components in netci Apr 14, 2018
@echesakov echesakov removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants