Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Commit

Permalink
Share CFRunLoop for FSEventStreams in FileSystemWatcher on OSX (#33865)
Browse files Browse the repository at this point in the history 
* Share CFRunLoop for FSEventStreams in FileSystemWatcher on OSX

* Address review comments

* Add execution context capturing

* Fix nits

* Add some tests to check multiple watchers

* Address review comments

* Update FileSystemWatcher tests

* Add timeout for non-expected events

* Wrap FileSystemWatcher_File_Create_EnablingDisablingNotAffectRaisingEvent test in ExecuteWithRetry helper method and mark it with Outerloop

* Wrap FileSystemWatcher_File_Create_WatchOwnPath test in ExecuteWithRetry helper method

* Move disposing FileSystemWatcher instances to a finally section in FileSystemWatcher_File_Create_ForceLoopRestart test

* Use null-conditional operator before disposing
  • Loading branch information
@MaximLipnin @stephentoub
MaximLipnin authored and stephentoub committed Dec 20, 2018
1 parent 8a05b3f commit 8a06434
Show file tree
Hide file tree
Showing 5 changed files with 544 additions and 183 deletions.
Loading

0 comments on commit 8a06434

Please sign in to comment.