This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add TextReader/Writer Memory-based virtuals #24434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyKuhne
reviewed
Oct 4, 2017
| @@ -117,6 +118,35 @@ public override int Read(char[] buffer, int index, int count) | |||
| return n; | |||
| } | |||
|
|
|||
| public override int Read(Span<char> destination) | |||
| { | |||
| if (GetType() != typeof(StringReader)) | |||
There was a problem hiding this comment.
Do we want to add the comment on why we do the check for derived classes?
There was a problem hiding this comment.
Sure, I'll add comments.
ahsonkhan
reviewed
Oct 4, 2017
| @@ -1435,8 +1435,12 @@ public partial class StringReader : System.IO.TextReader | |||
| public override int Peek() { throw null; } | |||
| public override int Read() { throw null; } | |||
| public override int Read(char[] buffer, int index, int count) { throw null; } | |||
| public override int Read(System.Span<char> destination) { throw null; } | |||
There was a problem hiding this comment.
nit: Is specifying System required in the type name? If not, remove (here and elsewhere) to be consistent.
There was a problem hiding this comment.
Using the full type name is consistent with how the ref generator tool generates the code.
ahsonkhan
reviewed
Oct 5, 2017
| @@ -1523,6 +1533,7 @@ public abstract partial class TextWriter : System.MarshalByRefObject, System.IDi | |||
| public virtual System.Threading.Tasks.Task WriteAsync(char value) { throw null; } | |||
| public System.Threading.Tasks.Task WriteAsync(char[] buffer) { throw null; } | |||
| public virtual System.Threading.Tasks.Task WriteAsync(char[] buffer, int index, int count) { throw null; } | |||
| public virtual System.Threading.Tasks.Task WriteAsync(ReadOnlyMemory<char> source, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; } | |||
There was a problem hiding this comment.
Using the full type name is consistent with how the ref generator tool generates the code.
There are some places where the full type name is not being used.
|
@dotnet/dnceng, I'm seeing an error I've not seen before. The given tests completed successfully, and then there was some kind of connection failure in the infrastructure: |
|
@dotnet/dnceng, another example of the tests finishing successfully and then the leg failing: |
|
@dotnet/dnceng, and an "Execution may have been compromised" error? |
pjanotti
pushed a commit
to pjanotti/corefx
that referenced
this pull request
Oct 31, 2017
* Add Memory-based Read/WriteAsync virtuals to TextReader/Writer * Override Span/Memory-based APIs on StringReader/Writer * Address PR feedback
|
Just hit a Needing/Wanting Cancellation token support for StreamReader.ReadLineAsync() just now, Was it added in 2.1.0 >> only, or still open-not in yet? |
|
These overloads were added in 2.1. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Add Memory-based Read/WriteAsync virtuals to TextReader/Writer * Override Span/Memory-based APIs on StringReader/Writer * Address PR feedback Commit migrated from dotnet/corefx@03d7056
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And override both the Span and Memory-based virtuals on StringReader and StringWriter.
Fixes https://github.com/dotnet/corefx/issues/22410
Fixes https://github.com/dotnet/corefx/issues/22406
Fixes https://github.com/dotnet/corefx/issues/22411
cc: @JeremyKuhne, @pjanotti, @KrzysztofCwalina, @ahsonkhan