This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Adding tests for the new Math APIs #33359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dotnet-bot test this please |
|
Need to fix the handling of |
|
Handling is being fixed in dotnet/coreclr#20912 |
|
CC. @ViktorHofer, @eerhardt |
eerhardt
reviewed
Nov 14, 2018
eerhardt
reviewed
Nov 14, 2018
src/System.Runtime.Extensions/tests/System/MathTests.netcoreapp.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Nov 14, 2018
eerhardt
reviewed
Nov 14, 2018
|
@ViktorHofer, @eerhardt, any other feedback here? |
stephentoub
approved these changes
Nov 15, 2018
jlennox
pushed a commit
to jlennox/corefx
that referenced
this pull request
Dec 16, 2018
* Updating the System.Runtime.Extensions ref assembly to include the new math functions * Adding tests to cover the new math functions
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Updating the System.Runtime.Extensions ref assembly to include the new math functions * Adding tests to cover the new math functions Commit migrated from dotnet/corefx@2999b45
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the tests for dotnet/coreclr#20788