Mirror changes from dotnet/coreclr

[dotnet-maestro-bot]

This PR contains mirrored changes from dotnet/coreclr

Please REBASE this PR when merging

cc @tannergooding

[danmoseley]

@tannergooding looks like some fixups are needed on corefx side.

[tannergooding]

@danmosemsft, yes it requires this #33447, as well as the CoreCLR side changes since the code has moved to S.P.Corelib.

As per dotnet/coreclr#20934, we are going to do the CoreCLR package update and this together.

• If this ends up blocking anything, feel free to tag me and I will fallback to using #ifdef, which will work but cause some noisy churn and an additional couple PRs after everything goes through.

[danmoseley]

sounds good

[tannergooding]

This contains the original commit, untouched, so it can be rebased.
This also includes the following three PRs, squashed together (as would have been done in #33450):

• Update CoreClr, CoreFx, CoreFxOptimizationData, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview-27113-06, preview.18563.5, master-20181113-0044, preview-27113-04, beta-27113-00, beta-27113-00, respectively (master) #33450
• Removing the Utf8Parser and Utf8Formatter from System.Memory, now that it is in S.P.Corelib #33447
• Fixing the Math/MathF Min and Max tests #33436

CC. @stephentoub, @danmosemsft, @jkotas

[tannergooding]

There was a bug: dotnet/coreclr#20967

[tannergooding]

Updated to use the latest commit from #33450

[stephentoub]

@tannergooding, some more failures (in the UWP NETNative build):

D:\j\workspace\windows-TGrou---c60886e1\src\shims\ApiCompat.proj(82,5): error : TypesMustExist : Type 'System.Buffers.StandardFormat' does not exist in the implementation but it does exist in the contract.
D:\j\workspace\windows-TGrou---c60886e1\src\shims\ApiCompat.proj(82,5): error : TypesMustExist : Type 'System.Buffers.Text.Utf8Formatter' does not exist in the implementation but it does exist in the contract.
D:\j\workspace\windows-TGrou---c60886e1\src\shims\ApiCompat.proj(82,5): error : TypesMustExist : Type 'System.Buffers.Text.Utf8Parser' does not exist in the implementation but it does exist in the contract.
D:\j\workspace\windows-TGrou---c60886e1\src\shims\ApiCompat.proj(90,5): error : ApiCompat failed comparing netstandard to uapaot

[tannergooding]

some more failures (in the UWP NETNative build)

Just finishing validating the fix locally (adding these to the compat baseline and telling netcoreappaot to ignore missing types until their baseline can be updated).

[tannergooding]

test this please

[tannergooding]

hmmm... full set of jobs still aren't triggering.

Edit: there we go, commenting fixed it.

[danmoseley]

D:\j\workspace\windows-TGrou---c60886e1\src\shims\ApiCompat.proj(82,5): error : TypesMustExist : Type 'System.Buffers.StandardFormat' does not exist in the implementation but it does exist in the contract.
D:\j\workspace\windows-TGrou---c60886e1\src\shims\ApiCompat.proj(82,5): error : TypesMustExist : Type 'System.Buffers.Text.Utf8Formatter' does not exist in the implementation but it does exist in the contract.
D:\j\workspace\windows-TGrou---c60886e1\src\shims\ApiCompat.proj(82,5): error : TypesMustExist : Type 'System.Buffers.Text.Utf8Parser' does not exist in the implementation but it does exist in the contract.
D:\j\workspace\windows-TGrou---c60886e1\src\shims\ApiCompat.proj(90,5): error : ApiCompat failed comparing netstandard to uapaot

Maybe GenFacadesIgnoreMissingTypes doesn't work and you need an ApiCompatBaseline.uapaot.txt

[tannergooding]

Maybe GenFacadesIgnoreMissingTypes doesn't work and you need an ApiCompatBaseline.uapaot.txt

I need both. I hit the case where /p:BaselineAllAPICompatError=true does nothing if you don't specify /t:Rebuild

[tannergooding]

@joperezr assisted me, I needed to also update the ApiCompat baseline under src\shims.

[tannergooding]

I also logged https://github.com/dotnet/corefx/issues/33464, to ensure that these steps are properly documented and easy to find when the failures occur

[tannergooding]

Everything passed except for the NetFX test run (which failed because the Math test changes weren't properly conditioned). Everything is expected to pass this time. (sorry for the delay)