This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Use product version in RuntimeInformation.FrameworkDescription #35516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
approved these changes
Feb 22, 2019
| AssemblyFileVersionAttribute attr = (AssemblyFileVersionAttribute)(typeof(object).GetTypeInfo().Assembly.GetCustomAttribute(typeof(AssemblyFileVersionAttribute))); | ||
| string expected = string.Format(".NET Core {0}", attr.Version); | ||
| Assert.Equal(expected, RuntimeInformation.FrameworkDescription); | ||
| Assert.True(RuntimeInformation.FrameworkDescription.StartsWith(".NET Core")); |
There was a problem hiding this comment.
Nit: could you add FraneworkDescription as part of a second argument so we're see what it is if the assert fails?
This was referenced Jan 31, 2020
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…t/corefx#35516) * Use product version in RuntimeInformation.FrameworkDescription * Include FrameworkDescription in the Assert * Strip the git hash in the fallback Commit migrated from dotnet/corefx@db95b37
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to https://github.com/dotnet/corefx/issues/35361