This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Make PathAssemblyResolver handle Retargetable #42768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yToken if reference is Retargetable (dotnet#40581)
|
Fixes dotnet/runtime#730 |
Anipik
approved these changes
Dec 10, 2019
ericstj
added
Servicing-consider
This comment has been minimized.
This comment has been minimized.
|
Failure here appears to be related to how we support netcoreapp3.1 package tests. We didn't catch it in the 3.1 SDK update PR since we weren't building packages at that time. I'll fix this in the package testing infra. |
|
Hold this until 3.1.2, as I think the other fix is slipping too, and aspnetcore is just about ready to go. |
mmitche
added
the
* NO MERGE *
|
@mmitche where are we at for 3.1.2? |
|
Not started yet. Waiting on the last signoffs for 3.1.1 |
|
Not until branding is updated. |
|
Sure, I meant we can remove "no-merge" ? |
Anipik
removed
the
* NO MERGE *
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release/3.1 port of fca6032 + package authoring.