Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

[release/3.1] Add Fedora 33 runtime ids #42871

Merged
merged 3 commits into from
Mar 26, 2020
Merged

Conversation

omajid
Copy link
Member

@omajid omajid commented Feb 24, 2020

Fedora 32 is gearing up for release[1], and in-development version of Fedora has been officially labelled as being Fedora 33:

$ podman run -it fedora:33 cat /etc/os-release
NAME=Fedora
VERSION="33 (Container Image)"
ID=fedora
VERSION_ID=33
VERSION_CODENAME=""
PLATFORM_ID="platform:f33"
PRETTY_NAME="Fedora 33 (Container Image)"
ANSI_COLOR="0;34"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:33"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/rawhide/system-administrators-guide/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=rawhide
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=rawhide
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Container Image"
VARIANT_ID=container

[1] https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html

This is a backport of dotnet/runtime#32752

Fedora 32 is gearing up for release[1], and in-development version of
Fedora has been offically labelled as being Fedora 33:

    $ podman run -it fedora:33 cat /etc/os-release
    NAME=Fedora
    VERSION="33 (Container Image)"
    ID=fedora
    VERSION_ID=33
    VERSION_CODENAME=""
    PLATFORM_ID="platform:f33"
    PRETTY_NAME="Fedora 33 (Container Image)"
    ANSI_COLOR="0;34"
    LOGO=fedora-logo-icon
    CPE_NAME="cpe:/o:fedoraproject:fedora:33"
    HOME_URL="https://fedoraproject.org/"
    DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/rawhide/system-administrators-guide/"
    SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
    BUG_REPORT_URL="https://bugzilla.redhat.com/"
    REDHAT_BUGZILLA_PRODUCT="Fedora"
    REDHAT_BUGZILLA_PRODUCT_VERSION=rawhide
    REDHAT_SUPPORT_PRODUCT="Fedora"
    REDHAT_SUPPORT_PRODUCT_VERSION=rawhide
    PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
    VARIANT="Container Image"
    VARIANT_ID=container

[1] https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html
@omajid omajid changed the title Add Fedora 33 runtime ids [release/3.1] Add Fedora 33 runtime ids Feb 24, 2020
@omajid omajid requested a review from bartonjs February 25, 2020 17:08
@bartonjs bartonjs requested a review from safern February 27, 2020 19:04
@@ -27,7 +27,7 @@
<PackageVersion Condition="'$(PackageVersion)' == ''">4.7.0</PackageVersion>
<!-- major.minor.release version of the platforms package we're currently building
Pre-release will be appended during build -->
<PlatformPackageVersion>3.1.0</PlatformPackageVersion>
<PlatformPackageVersion>3.1.1</PlatformPackageVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@safern Does this require rebuilding the package index with this PR? Or is that something that gets handled automagically?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@safern Ping?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericstj...@safern is out

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is sufficient. @Anipik when do we typically add the stable version to the index?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we add it after the package has been pushed to the nuget. i.e on the day of release with the branding change.

@omajid
Copy link
Member Author

omajid commented Mar 13, 2020

Can someone please merge this? Thanks

@ericstj
Copy link
Member

ericstj commented Mar 13, 2020

This is for a servicing branch, has this been taken to tactics for servicing approval?

@ericstj ericstj added the Servicing-consider Issue for next servicing release review label Mar 13, 2020
@ericstj
Copy link
Member

ericstj commented Mar 13, 2020

I've added servicing-consider. This will need to go through shiproom. FWIW, 3.1 has been locked for a couple weeks so this wouldn't have made it into 3.1.3. It'll need to be in 3.1.4.

@omajid
Copy link
Member Author

omajid commented Mar 13, 2020

FWIW, ship room has previously said that RID-bumps are considered "tell-mode" not "ask-mode".

@ericstj
Copy link
Member

ericstj commented Mar 13, 2020

Got it, I'd expect that too.

@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Mar 17, 2020
@danmoseley danmoseley added this to the 3.1.4 milestone Mar 24, 2020
@Anipik Anipik merged commit ef1643c into dotnet:release/3.1 Mar 26, 2020
@omajid omajid mentioned this pull request Aug 17, 2020
15 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants