Microsoft.Diagnostics.NETCore.Client Implementation #617

sywhang · 2019-11-14T18:27:18Z

This is the initial implementation of Microsoft.Diagnostics.NETCore.Client library proposed by #574.

This will be released with version 1.0.0-preview, and when I feel that enough customers have validated it that we can match it with the rest of the diagnostics OOB packages and bump up the version to 3.1.

There are a couple of remaining items to do for testing and I've filed the issues below to track them:

Add profiler attach test (wasn't added since this PR was getting too large) - [Microsoft.Diagnostics.NETCore.Client] Add profiler test #651
Clean up the tracee discovery logic in TestRunner - [Microsoft.Diagnostics.NETCore.Client] Refactor tracee discovery logic #652

cc @tommcdon

…mplementation

src/Tools/dotnet-dump/Dumper.cs

src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/DiagnosticsClient.cs

noahfalk

Lgtm, modulo the comments I left for you. Thanks Sung!

src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/DiagnosticsClient.cs

src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/EventPipeProvider.cs

src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/EventPipeSession.cs

noahfalk · 2019-11-27T11:48:55Z

src/tests/Microsoft.Diagnostics.NETCore.Client/CommonHelper.cs

+    public class CommonHelper
+    {
+        public static string HostExe = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? 
+            "..\\..\\..\\..\\..\\.dotnet\\dotnet.exe" : "../../../../../.dotnet/dotnet";


The TestConfiguration class has a HostExe property so that we won't have to hard-code these paths.

noahfalk · 2019-11-27T11:52:26Z

src/tests/Microsoft.Diagnostics.NETCore.Client/CommonHelper.cs

+
+        public static string GetTraceePath()
+        {
+            var curPath = Directory.GetCurrentDirectory();


Is this assuming that current directory will be the same as the path to this assembly? I'd recommend using the Assembly.GetExecutingAssembly().Location instead. Taking dependencies on current path causes tests to fail when people run them ad-hoc from an unexpected directory.

noahfalk · 2019-11-27T12:05:22Z

src/tests/Microsoft.Diagnostics.NETCore.Client/TestRunner.cs

+            }
+
+            outputHelper.WriteLine($"[{DateTime.Now.ToString()}] Sleeping for {timeoutInMS} ms.");
+            Thread.Sleep(timeoutInMS);


Sleeping in tests is unreliable on slow machines and can become very wasteful on fast machines. Initially it seems like a few seconds won't matter, but it really can add up as people clone the pattern into more tests, run the same tests over and over in different configurations, and keep increasing the sleep times as quick workarounds for tests that fail on incredibly slow machines.

If the goal is to wait for a the domain socket to be created then I recommend polling for it at a fairly short interval such as every 50ms. If it hasn't been created within the timeout period then trigger an error from the test and exit.

noahfalk · 2019-11-27T12:12:59Z

src/tests/Microsoft.Diagnostics.NETCore.Client/TestRunner.cs

+        {
+            startInfo = new ProcessStartInfo(CommonHelper.HostExe, testExePath);
+            startInfo.UseShellExecute = false;
+            startInfo.RedirectStandardOutput = true;


If the child process logs a bunch of output to stdout and you don't read it then the child will eventually block waiting for it to be read. You'd either need to ensure that no tracee writes too much to stdout, or handle reading it, (or use ProcessRunner which already solved this problem)

noahfalk · 2019-11-27T12:18:23Z

src/tests/Microsoft.Diagnostics.NETCore.Client/WriteDumpTests.cs

+        /// A test that writes all the different types of dump file
+        /// </summary>
+        [Fact]
+        public void WriteAllDumpTypesTest()


You might want to check with Mike if this test is valuable given other tests we already have that verify the content of different kinds of dumps.

src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/EventPipeSessionConfiguration.cs

jorive · 2019-11-27T23:29:57Z

src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/EventPipeSession.cs

+
+namespace Microsoft.Diagnostics.NETCore.Client
+{
+    public class EventPipeSession : IDisposable


nit: sealed

src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/EventPipeSession.cs

jorive · 2019-11-27T23:35:09Z

src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsIpc/IpcClient.cs

+
+namespace Microsoft.Diagnostics.NETCore.Client
+{
+    internal class IpcClient


nit: sealed

src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsIpc/IpcHeader.cs

jorive · 2019-11-27T23:41:30Z

src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsIpc/IpcMessage.cs

+            Header = header;
+        }
+
+        public IpcMessage(DiagnosticsServerCommandSet commandSet, byte commandId, byte[] payload = null)


nit: could invoke ctor above.

jorive · 2019-11-27T23:42:13Z

src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsIpc/IpcMessage.cs

+    }
+
+
+    internal class IpcMessage


nit: sealed

src/Tools/dotnet-trace/Extensions.cs

src/tests/Microsoft.Diagnostics.NETCore.Client/CommonHelper.cs

josalem

Looks great! I had a couple minor comments, but otherwise I'm excited to ship it! Since you've got some issues filed for doing polishing the testing, I'll follow up with you offline about the test runner and review it as part of that work.

src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/DiagnosticsClient.cs

src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/EventPipeProvider.cs

src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsIpc/IpcClient.cs

josalem · 2019-11-28T01:30:09Z

src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsIpc/IpcClient.cs

+                    throw new ServerNotAvailableException($"Process {processId} not running compatible .NET Core runtime.");
+                }
+                string path = Path.Combine(IpcRootPath, ipcPort);
+                var remoteEP = new UnixDomainSocketEndPoint(path);


I'm pretty certain this API is netstandard2.1, so we'll have to do something about this if we want to target older runtimes or netstandards. I don't think this is in the scope of this PR though 😄

src/Tools/dotnet-gcdump/CommandLine/CollectCommandHandler.cs

src/Tools/dotnet-trace/CommandLine/Commands/StopCommandHandler.cs

src/Tools/dotnet-trace/Program.cs

hoyosjs · 2019-12-05T16:49:56Z

/azp run

azure-pipelines · 2019-12-05T16:50:06Z

Azure Pipelines successfully started running 1 pipeline(s).

hoyosjs · 2019-12-05T19:01:11Z

@sywhang you're ready to go

This is the initial implementation of Microsoft.Diagnostics.NETCore.Client library. This will be released with version 1.0.0-preview, and when I feel that enough customers have validated it that we can match it with the rest of the diagnostics OOB packages and bump up the version to 3.1.

* Microsoft.Diagnostics.NETCore.Client Implementation (#617) This is the initial implementation of Microsoft.Diagnostics.NETCore.Client library. This will be released with version 1.0.0-preview, and when I feel that enough customers have validated it that we can match it with the rest of the diagnostics OOB packages and bump up the version to 3.1. * add .NET Standard 2.0 for diagnostics client library (#700) * Make MultiplePublishedProcessTest more stable (#701) * Make MultiplePublishedProcessTest more stable * Bump up DiagnosticsClient library version to 0.2.0 (#704)

* Update dependencies from https://github.com/aspnet/AspNetCore build 20191125.10 (#650) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha1.19575.10 * Add documentation on EventCounters (#605) * Adding some initial EventCounters documentation * Add more stuff about incrementingeventcounter * Add pictures * Add more description about how to write your own counter * Add out-of-proc consumption, more samples * formatting * more formatting * Add section about concurrency * cleanup, formatting * format * Address PR feedback * Avoid exceptions when console is not available (#644) * Do not manipulate cursor if Console not available * Use console.GetTerminal() to test for console * Update dependencies from https://github.com/aspnet/AspNetCore build 20191127.15 (#655) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha1.19577.15 * Update dependencies from https://github.com/aspnet/AspNetCore build 20191128.4 (#656) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha1.19578.4 * Update dependencies from https://github.com/aspnet/AspNetCore build 20191201.2 (#657) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha1.19601.2 * Update dependencies from https://github.com/aspnet/AspNetCore build 20191202.2 (#660) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha1.19602.2 * Update dependencies from https://github.com/aspnet/AspNetCore build 20191203.5 (#665) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha1.19603.5 * add missing README.md files for global tools (#662) * add missing README.md files for global tools * use relative link * SpeedScope handles only CPU samples, events are not supported (#661) * dotnet-counters JSON Exporter improvements (#666) * make timestamp non culture-sensitive, change 'counter type' to 'counterType' * Remove more spaces from the JSON * Microsoft.Diagnostics.NETCore.Client Implementation (#617) This is the initial implementation of Microsoft.Diagnostics.NETCore.Client library. This will be released with version 1.0.0-preview, and when I feel that enough customers have validated it that we can match it with the rest of the diagnostics OOB packages and bump up the version to 3.1. * Update dependencies from https://github.com/aspnet/AspNetCore build 20191205.16 (#672) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha1.19605.16 * Upgrade to latest System.CommandLine version (#668) Upgrade to latest System.CommandLine version Use collection initializers * Prepare SOS for single file support and add desktop CLR support (#658) Prepare SOS for single file support and add desktop CLR support Add defines and functions for the runtime, dac and dbi modules/dlls names. Also supports desktop CLR Add minidump retry for ERROR_PARTIAL_COPY * Add EventPipe events test (#659) * Fix ContentionEvents test to make it more stable (#683) * Update dependencies from https://github.com/aspnet/AspNetCore build 20191210.3 (#684) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha1.19610.3 * Incorrect tool referenced (#687) * Fix GCEvent test being flakey (#689) * Fix GCEvent test being flakey * Fix build * [master] Update dependencies from aspnet/AspNetCore (#688) * Update dependencies from https://github.com/aspnet/AspNetCore build 20191211.17 - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha1.19611.17 * Update dependencies from https://github.com/aspnet/AspNetCore build 20191212.8 - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha1.19612.8 * Use darc runtime subscription versions for testing (#682) Use darc runtime subscription versions for testing Update arcade to version 5.0.0-beta.19608.1 Replace install scripts with InstallRuntimes.proj (thanks to Juan). Add build.ps1 on Windows. Build-Native.cmd just builds the native bits now. Combine build.sh and build-native.sh scripts. Remove -publish from scripts Add running sosstatus command on SOSRunner errors. Always set the host runtime (SOSHostRuntime) in test configs Fix RuntimeFrameworkVersion config property usage Sign, package and publish only if build legs successful Issues: https://github.com/dotnet/diagnostics/issues/423 https://github.com/dotnet/diagnostics/issues/480 * Update dependencies from https://github.com/aspnet/AspNetCore build 20191213.21 (#695) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha1.19613.21 * Update dependencies from https://github.com/dotnet/arcade build 20191213.1 (#694) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19613.1 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.19613.1 * Fix various issues (#690) Issue: https://github.com/dotnet/diagnostics/issues/673 SymbolReader doesn't support UNC symbol paths. Issue: https://github.com/dotnet/diagnostics/issues/674 Add -all gcroot option to docs. Issue: https://github.com/dotnet/diagnostics/issues/632 Better doc clrstack -all and other options. Issue: https://github.com/dotnet/diagnostics/issues/576 Doc RHEL lldb install. Issue: https://github.com/dotnet/diagnostics/issues/483 Add setclrpath command to dotnet-dump on linux. Mentioned in https://github.com/dotnet/diagnostics/issues/624 Issue: https://github.com/dotnet/diagnostics/issues/590 Add -timeout option to SetSymbolServer command. Issue: https://github.com/dotnet/diagnostics/issues/602 Use CommandPlatform on Windows specific commands Don't use the desktop clr to host SOS managed code. Don't allow dumplog on desktop clr target. Cleanup SOSHost "is runtime" checks. Removed unneeded install of the x86 SDK in InstallRuntimes.proj Fix SOS on Windows where it needs to download the DAC but the symbol server store was never initialized from the .sympath. This is even more important when both coreclr and desktop clr are loaded in the process/minidump. Update to 3.0.1 runtime version * Fix scheduled build (#696) * Revert back to 3.0.100 SDK version (#697) * Update dependencies from https://github.com/aspnet/AspNetCore build 20191214.22 (#698) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.19614.22 * Update dependencies from https://github.com/dotnet/arcade build 20191215.1 (#699) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19615.1 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.19615.1 * add .NET Standard 2.0 for diagnostics client library (#700) * Update windows-instructions.md * Make MultiplePublishedProcessTest more stable (#701) * Make MultiplePublishedProcessTest more stable * Make scheduled builds full official builds (#703) Publish all the artifacts to the blob feeds for the scheduled builds so the vendors don't have to do thier error prone builds. Some minor cleanup to remove some pipeline warnings. Change ClrStack casing in help docs to be consistent Remove SDK entry in global.json so VS works Update version prefix to 5.0.0 * Bump up DiagnosticsClient library version to 0.2.0 (#704) * Revert _Pipeline_StreamDumpDir removal (#707) * Reduce predeftlsslot.h to the set that SOS actually depends on (#709) * Avoid NullReferenceException in case the code path is run under an incompatible runtime (#711) * Add verbose info to clrmodules command. (#712) Add version info to modules command. * [master] Update dependencies from aspnet/AspNetCore (#706) * Update dependencies from https://github.com/aspnet/AspNetCore build 20191216.1 - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.19616.1 * Update dependencies from https://github.com/aspnet/AspNetCore build 20191218.3 - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.19618.3 * Update clrmd to version 1.1.61812 (module size and version info fixes) (#715) * Update dependencies from https://github.com/aspnet/AspNetCore build 20191219.2 (#716) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.19619.2 * Initial commit (#714) * Fix EventPipe tests to use the new DiagnosticsClient library (#720) * Change all the EventPipe tests to use DiagnosticsClient library * Specify keyword for SentinelEventSource * Fix MethodEvents * Specify keywords for MyEventSource * Display rundown information when stopping trace (#721) * Remove legacy RuntimeClient library (#722) * [master] Update dependencies from aspnet/AspNetCore (#718) * Update dependencies from https://github.com/aspnet/AspNetCore build 20191220.1 - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.19620.1 * Update dependencies from https://github.com/aspnet/AspNetCore build 20191223.2 - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.19623.2 * Update dependencies from https://github.com/aspnet/AspNetCore build 20191226.3 - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.19626.3 * Update dependencies from https://github.com/aspnet/AspNetCore build 20191227.1 - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.19627.1 * [master] Update dependencies from dotnet/arcade (#719) * Update dependencies from https://github.com/dotnet/arcade build 20191222.1 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19622.1 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.19622.1 * Update dependencies from https://github.com/dotnet/arcade build 20191229.1 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19629.1 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.19629.1 * [master] Update dependencies from dotnet/runtime (#713) * Update dependencies from https://github.com/dotnet/runtime build 20191218.3 - Microsoft.NETCore.App - 5.0.0-alpha.1.19618.3 * Update dependencies from https://github.com/dotnet/runtime build 20191219.11 - Microsoft.NETCore.App - 5.0.0-alpha.1.19619.11 * Update dependencies from https://github.com/dotnet/runtime build 20191220.3 - Microsoft.NETCore.App - 5.0.0-alpha.1.19620.3 * Update dependencies from https://github.com/dotnet/runtime build 20191221.1 - Microsoft.NETCore.App - 5.0.0-alpha.1.19621.1 * Update dependencies from https://github.com/dotnet/runtime build 20191222.1 - Microsoft.NETCore.App - 5.0.0-alpha.1.19622.1 * Update dependencies from https://github.com/dotnet/runtime build 20191223.2 - Microsoft.NETCore.App - 5.0.0-alpha.1.19623.2 * Update dependencies from https://github.com/dotnet/runtime build 20191226.2 - Microsoft.NETCore.App - 5.0.0-alpha.1.19626.2 * Update dependencies from https://github.com/dotnet/runtime build 20191227.5 - Microsoft.NETCore.App - 5.0.0-alpha.1.19627.5 Co-authored-by: Mike McLaughlin <mikem@microsoft.com> * Fix sample code to actually print string name of the CLR events (#728) * Some misc fixes to counters doc (#729) * Misc cleanup and fixes found during runtime change testing. Change ctrl-c message issue: https://github.com/dotnet/diagnostics/issues/532 Revert 5.0.x runtime version until issue https://github.com/dotnet/runtime/issues/1229 is fixed. * Abstract all the runtime specific info and class. Add IRuntime/Runtime classes. The code to get the runtime module address/size info, DAC/DBI file path, create/get the SOS DAC process instance and to create/get the ICorDebug process instance to the Runtime class implementation. It was moved mostly intack with some type and function name changes. Added -desktop and -netcore options to the !sosstatus command to switch between runtimes. Eventually SOSHosting will provide the IRuntime instance when hosted under dotnet-dump. Fix unloading/reloading SOS (under windbg) issue: https://github.com/dotnet/diagnostics/issues/386 Flush process specific global state when process terminates issue: https://github.com/dotnet/diagnostics/issues/479 * Add dual .NET Core/desktop CLR runtime test Added an desktop host native DLL that the modified WebApp3 debuggee optionally pinvokes to start the desktop CLR. An modified SymbolTestDll is the managed assembly that this desktop host loads and runs. Fixed bug in GetClrModuleImages. * Update dependencies from https://github.com/dotnet/arcade build 20200105.1 (#730) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20055.1 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20055.1 * Update FAQ.md * [master] Update dependencies from dotnet/runtime (#725) * Update dependencies from https://github.com/dotnet/runtime build 20191230.4 - Microsoft.NETCore.App - 5.0.0-alpha.1.19630.4 * Update dependencies from https://github.com/dotnet/runtime build 20191231.3 - Microsoft.NETCore.App - 5.0.0-alpha.1.19631.3 * Update dependencies from https://github.com/dotnet/runtime build 20200101.1 - Microsoft.NETCore.App - 5.0.0-alpha.1.20051.1 * Update dependencies from https://github.com/dotnet/runtime build 20200102.3 - Microsoft.NETCore.App - 5.0.0-alpha.1.20052.3 * Update dependencies from https://github.com/dotnet/runtime build 20200103.4 - Microsoft.NETCore.App - 5.0.0-alpha.1.20053.4 * Update dependencies from https://github.com/dotnet/runtime build 20200104.2 - Microsoft.NETCore.App - 5.0.0-alpha.1.20054.2 * Update dependencies from https://github.com/dotnet/runtime build 20200105.4 - Microsoft.NETCore.App - 5.0.0-alpha.1.20055.4 * Update dependencies from https://github.com/dotnet/runtime build 20200106.3 - Microsoft.NETCore.App - 5.0.0-alpha.1.20056.3 * Update dependencies from https://github.com/dotnet/runtime build 20200107.6 - Microsoft.NETCore.App - 5.0.0-alpha.1.20057.6 Co-authored-by: Mike McLaughlin <mikem@microsoft.com> * Handle glibc sys/sysctl.h deprecation (#27048) (#681) glibc has deprecated sys/sysctl.h: In file included from /coreclr/src/pal/src/misc/sysinfo.cpp:32: /usr/include/sys/sysctl.h:21:2: error: "The <sys/sysctl.h> header is deprecated and will be removed." [-Werror,-W#warnings] #warning "The <sys/sysctl.h> header is deprecated and will be removed." ^ 1 error generated. Fix that by preferring sysconf and only including sys/sysctl.h if HAVE_SYSCONF is not true. This mirrors the order of the implementation code in this file (sysinfo.cpp) which checks for HAVE_SYSCONF before HAVE_SYSCTL. Fixes #27008 Co-authored-by: Omair Majid <omajid@redhat.com> * [master] Update dependencies from aspnet/AspNetCore (#726) * Update dependencies from https://github.com/aspnet/AspNetCore build 20191230.2 - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.19630.2 * Update dependencies from https://github.com/aspnet/AspNetCore build 20200102.2 - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.20052.2 * Update dependencies from https://github.com/aspnet/AspNetCore build 20200104.2 - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.20054.2 * Update dependencies from https://github.com/aspnet/AspNetCore build 20200106.1 - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.20056.1 * Update dependencies from https://github.com/aspnet/AspNetCore build 20200106.6 - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.20056.6 Co-authored-by: Mike McLaughlin <mikem@microsoft.com> * Update FAQ.md * Update dependencies from https://github.com/dotnet/runtime build 20200108.9 (#735) - Microsoft.NETCore.App - 5.0.0-alpha.1.20058.9 * Fix newline formatting for dotnet-trace provider info (#737) * Add --clrevents flag to dotnet-trace (#738) * Add clrevents flag * Ignore clrevents if providers is already specified * Docs change * Change the error message a little bit * case insensitive comparison for keywords, add clreventlevel option * Threw back in a line that was deleted accidentally * Add test for CLR provider parsing * use stringcomparer instead of tolower * Update dependencies from https://github.com/dotnet/runtime build 20200109.11 (#739) - Microsoft.NETCore.App - 5.0.0-alpha.1.20059.11 * Update dependencies from https://github.com/dotnet/runtime build 20200110.7 (#741) - Microsoft.NETCore.App - 5.0.0-alpha.1.20060.7 * Update dependencies from https://github.com/dotnet/runtime build 20200111.3 (#743) - Microsoft.NETCore.App - 5.0.0-alpha.1.20061.3 * Update dependencies from https://github.com/dotnet/arcade build 20200112.1 (#744) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20062.1 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20062.1 * Update dependencies from https://github.com/dotnet/runtime build 20200112.3 (#745) - Microsoft.NETCore.App - 5.0.0-alpha.1.20062.3 * Fix line number issues in SOS (#734) Fix line number issues in SOS The change is to subtract 1 from the IP used to get the source/line info when the stack frame is a leaf node. For hardware exceptions, the IP has already been adjusted (+1) by the runtime so they cancel out. Fixes in SOS the same issues reported in https://github.com/dotnet/coreclr/issues/27765 and https://github.com/dotnet/coreclr/issues/25740 for the runtime's unhandled exception message. Add some more PrintException -lines testing for thrown and hardware exceptions. Gracefully fail with runtime module size == 0. Fix "clrmodules" failure our vendors found. Add line number (LineNum) check testcase * Update dependencies from https://github.com/dotnet/runtime build 20200113.7 (#747) - Microsoft.NETCore.App - 5.0.0-alpha.1.20063.7 * Update dependencies from https://github.com/dotnet/runtime build 20200114.4 (#750) - Microsoft.NETCore.App - 5.0.0-alpha.1.20064.4 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200114.4 (#751) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.20064.4 Co-authored-by: Mike McLaughlin <mikem@microsoft.com> * Change Versions.props so darc updates don't conflict (#752) * Update dependencies from https://github.com/dotnet/runtime build 20200115.4 (#755) - Microsoft.NETCore.App - 5.0.0-alpha.1.20065.4 * Build Windows arm64 version of SOS. (#754) Build Windows arm64 version of SOS. Make sure that the "BuildArch" msbuild property is always passed to managed and native builds. Add the arm64 SOS to the various packages and zip files. The diasymreader package for Windows PDB support is currently disabled for arm64 waiting for issue https://github.com/dotnet/diagnostics/issues/324 to be addressed. * Update dependencies from https://github.com/dotnet/runtime build 20200116.11 (#757) - Microsoft.NETCore.App - 5.0.0-alpha.1.20066.11 * Update dependencies from https://github.com/dotnet/runtime build 20200117.9 (#759) - Microsoft.NETCore.App - 5.0.0-alpha.1.20067.9 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200117.2 (#760) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.20067.2 * Update dependencies from https://github.com/dotnet/runtime build 20200118.4 (#762) - Microsoft.NETCore.App - 5.0.0-alpha.1.20068.4 * Update dependencies from https://github.com/dotnet/arcade build 20200118.1 (#763) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20068.1 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20068.1 * Update dependencies from https://github.com/dotnet/runtime build 20200119.2 (#764) - Microsoft.NETCore.App - 5.0.0-alpha.1.20069.2 * Update dependencies from https://github.com/dotnet/runtime build 20200120.4 (#765) - Microsoft.NETCore.App - 5.0.0-alpha.1.20070.4 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200120.2 (#766) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.20070.2 * Misc SOS fixes (#758) Misc SOS fixes Change "dbgout" command not to require EE or DAC (use INIT_API_EXT). Fix case where the DAC is already in the temp directory because of a loadsymbols command when symlink'ing it on Linux. Allow just setsymbolserver -log without any other options. * Update dependencies from https://github.com/dotnet/runtime build 20200121.7 (#768) - Microsoft.NETCore.App - 5.0.0-alpha.1.20071.7 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200121.6 (#769) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.20071.6 * Update dependencies from https://github.com/dotnet/runtime build 20200122.3 (#773) - Microsoft.NETCore.App - 5.0.0-alpha.1.20072.3 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200123.2 (#775) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.20073.2 * Update dependencies from https://github.com/dotnet/runtime build 20200123.8 (#774) - Microsoft.NETCore.App - 5.0.0-alpha.1.20073.8 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200124.1 (#777) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.20074.1 * Update dependencies from https://github.com/dotnet/runtime build 20200124.8 (#776) - Microsoft.NETCore.App - 5.0.0-alpha.1.20074.8 * Update dependencies from https://github.com/dotnet/runtime build 20200125.5 (#778) - Microsoft.NETCore.App - 5.0.0-alpha.1.20075.5 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200125.3 (#779) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.20075.3 * Update dependencies from https://github.com/dotnet/arcade build 20200126.3 (#780) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20076.3 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20076.3 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200126.1 (#782) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.20076.1 * Update dependencies from https://github.com/dotnet/runtime build 20200126.2 (#781) - Microsoft.NETCore.App - 5.0.0-alpha.1.20076.2 * Changing the output text to say 'dump' rather than 'minidump' to avoid confusion with the minidump file format over in windows land. (#772) * Update dependencies from https://github.com/dotnet/runtime build 20200127.11 (#783) - Microsoft.NETCore.App - 5.0.0-alpha.1.20077.11 * Update dependencies from https://github.com/dotnet/runtime build 20200128.2 (#786) - Microsoft.NETCore.App - 5.0.0-alpha.1.20078.2 * Show optimization tiers for runtime major version >= 3 (including 5) (#785) Show optimization tiers for runtime major version >= 3 (including 5) * Update dependencies from https://github.com/dotnet/aspnetcore build 20200129.7 (#787) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.20079.7 * Various misc changes and SOS fixes (#789) Misc build changes Fix source/line number support Make sure the ip doesn't get adjusted before the start of the function. Allow `!SuppressJitOptimization on` to be used before the runtime is loaded and on xplat Add display il map option to !u * Fix official build failures with latest runtime (#795) * [master] Update dependencies from dotnet/runtime (#793) * Update dependencies from https://github.com/dotnet/runtime build 20200130.10 - Microsoft.NETCore.App - 5.0.0-alpha.1.20080.10 * Update dependencies from https://github.com/dotnet/runtime build 20200201.1 - Microsoft.NETCore.App - 5.0.0-alpha.1.20101.1 * Update dependencies from https://github.com/dotnet/runtime build 20200201.3 - Microsoft.NETCore.App - 5.0.0-alpha.1.20101.3 * Update dependencies from https://github.com/dotnet/arcade build 20200201.2 (#796) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20101.2 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20101.2 * Update dependencies from https://github.com/dotnet/runtime build 20200202.3 (#797) - Microsoft.NETCore.App - 5.0.0-alpha.1.20102.3 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200203.9 (#799) - Microsoft.AspNetCore.App.Ref - 5.0.0-alpha.1.20103.9 * Update dependencies from https://github.com/dotnet/runtime build 20200203.10 (#798) - Microsoft.NETCore.App - 5.0.0-alpha.1.20103.10 * Add weak WinRT handle kind (#800) * Update dependencies from https://github.com/dotnet/aspnetcore build 20200205.1 (#802) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.1.20105.1 * Remove dead codes (#806) * Update dependencies from https://github.com/dotnet/aspnetcore build 20200207.8 (#813) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.1.20107.8 * Fix the Windows private runtime build testing problems (#807) Fix the Windows private runtime build testing problems Enable the "setclrpath" for Windows. Change the SOS test harness and scripts to set the runtime path for triage dumps. Add -privatebuildpath option to build scripts that installs the test runtimes, copies the private runtime build and on Windows regedit's the necessary keys to create dumps. Add private build registry cleanup. * Update dependencies from https://github.com/dotnet/arcade build 20200209.1 (#814) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20109.1 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20109.1 * Do not clear the screen if returning error at launch (#815) * Update dependencies from https://github.com/dotnet/aspnetcore build 20200210.4 (#822) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.1.20110.4 * Fix ps handler for elevated process (#749) * Make diagnostics client library tests not sleep (#742) * Make the diagnostics client library tests not sleep * Remove thread.sleep * task.delay instead of thread.sleep * Fix failing test * Properly encode semicolon in argument strings for EventPipeProvider (#824) * Add quotation to semicolon in argument string for EventPipeProvider * Add test * remove dup * Wrap the entire argument string in quotes instead * Add more test * Update dependencies from https://github.com/dotnet/aspnetcore build 20200211.6 (#828) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.1.20111.6 * Try to get UnixDomainSocketEndPoint from System.Core if not found in System.Net.Sockets (#826) Fixes #821 * Escape EventPipeProvider argument key as well (#825) * Escape EventPipeProvider argument key as well * put the brace where it was * Update dependencies from https://github.com/dotnet/aspnetcore build 20200212.5 (#830) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.1.20112.5 * Get UnixDomainSocketEndPoint using Type.GetType() to avoid FileNotFoundException (#829) Fixes #821 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200213.23 (#831) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.1.20113.23 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200214.15 (#833) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.1.20114.15 * [master] Update dependencies from dotnet/runtime (#827) * Update dependencies from https://github.com/dotnet/runtime build 20200212.1 - Microsoft.NETCore.App - 5.0.0-alpha.1.20112.1 * Update dependencies from https://github.com/dotnet/runtime build 20200212.12 - Microsoft.NETCore.App - 5.0.0-preview.1.20112.12 * Update dependencies from https://github.com/dotnet/runtime build 20200213.7 - Microsoft.NETCore.App - 5.0.0-preview.1.20113.7 * Update dependencies from https://github.com/dotnet/runtime build 20200214.8 - Microsoft.NETCore.App - 5.0.0-preview.1.20114.8 * Update dependencies from https://github.com/dotnet/runtime build 20200215.9 - Microsoft.NETCore.App - 5.0.0-preview.1.20115.9 * Update dependencies from https://github.com/dotnet/arcade build 20200216.1 (#834) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20116.1 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20116.1 * Update dependencies from https://github.com/dotnet/runtime build 20200217.2 (#835) - Microsoft.NETCore.App - 5.0.0-preview.1.20117.2 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200216.1 (#836) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.1.20116.1 * Update dependencies from https://github.com/dotnet/runtime build 20200217.8 (#838) - Microsoft.NETCore.App - 5.0.0-preview.1.20117.8 * Update dependencies from https://github.com/dotnet/runtime build 20200218.7 (#840) - Microsoft.NETCore.App - 5.0.0-preview.1.20118.7 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200218.8 (#841) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.1.20118.8 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200219.7 (#843) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.1.20119.7 * dotnet-gcdump: Update docs to include print verb * [master] Update dependencies from dotnet/runtime (#842) * Update dependencies from https://github.com/dotnet/runtime build 20200219.9 - Microsoft.NETCore.App - 5.0.0-preview.2.20119.9 * Update dependencies from https://github.com/dotnet/runtime build 20200220.8 - Microsoft.NETCore.App - 5.0.0-preview.2.20120.8 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200221.13 (#850) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.2.20121.13 * Microsoft.Diagnostics.NETCore.Client Documentation (#845) * some docs * More API descriptions * fix broken links * More link * link * cleanup * pr feedback * PR feedback * Update dependencies from https://github.com/dotnet/arcade build 20200223.1 (#851) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20123.1 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20123.1 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200224.10 (#853) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.2.20124.10 * Updates tryrun.cmake for cross build (#837) Fix cross build: ``` ... -- Performing Test UNGETC_NOT_RETURN_EOF CMake Error: TRY_RUN() invoked in cross-compiling mode, please set the following cache variables appropriately: UNGETC_NOT_RETURN_EOF_EXITCODE (advanced) UNGETC_NOT_RETURN_EOF_EXITCODE__TRYRUN_OUTPUT (advanced) For details see /home/viewizard/Desktop/diagnostics/artifacts/obj/Linux.armel.Release/TryRunResults.cmake -- Performing Test UNGETC_NOT_RETURN_EOF - Success ... ``` Related to cmake changes (starts from 3.14.0-rc3, https://gitlab.kitware.com/cmake/cmake/commit/92d9ec9bfb61d2cd35a82d6906de86c71350b865) More info: https://gitlab.kitware.com/cmake/cmake/issues/18973 * Update dependencies from https://github.com/dotnet/runtime build 20200225.1 (#854) - Microsoft.NETCore.App - 5.0.0-preview.2.20125.1 * Add SECURITY.md * Update dependencies from https://github.com/dotnet/aspnetcore build 20200225.12 (#857) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.2.20125.12 * Update dependencies from https://github.com/dotnet/runtime build 20200225.16 (#856) - Microsoft.NETCore.App - 5.0.0-preview.2.20125.16 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200226.7 (#863) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.2.20126.7 * Update dependencies from https://github.com/dotnet/runtime build 20200227.14 (#864) - Microsoft.NETCore.App - 5.0.0-preview.2.20127.14 * Update dependencies from https://github.com/dotnet/runtime build 20200228.16 (#865) - Microsoft.NETCore.App - 5.0.0-preview.2.20128.16 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200228.11 (#866) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.2.20128.11 * dotnet-gcdump: Update docs to include new print verb * Update dependencies from https://github.com/dotnet/runtime build 20200229.8 (#867) - Microsoft.NETCore.App - 5.0.0-preview.2.20129.8 * Update dependencies from https://github.com/dotnet/arcade build 20200301.1 (#868) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20151.1 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20151.1 * Update dependencies from https://github.com/dotnet/runtime build 20200301.4 (#869) - Microsoft.NETCore.App - 5.0.0-preview.2.20151.4 * Fix whitespace in SECURITY.md (#870) * Update dependencies from https://github.com/dotnet/runtime build 20200302.11 (#872) - Microsoft.NETCore.App - 5.0.0-preview.2.20152.11 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200302.3 (#873) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.2.20152.3 * Pipeline consolidation, added SDL and signature verification. (#852) * Consolidate CI and Build pipelines * Add source checks to pipelines - Disable CI. - Enable exclusions for documentation and license. * Encompass all prior jobs into a single job for SDL/Publishing v2 changes * Add Alpine to PR testing * Use Publishing v2 and run SDL on official builds This modifies how we publish symbols, usual packages, and runs policheck and crediscan against internal builds. This also runs signature validation, nuget validity, and sourcelink. * Delete UnicodeData.txt This was brought with the coreclr's pal but was deleted in dotnet/coreclr#24581 This was used to generate sources, but not automatically as part of the build. The generated file is checked in, and SOS's is already outdated. * Fix Policheck issues Fixes all the flagged terms except for API contracts, false positives, and files aquired from LLDB. * Add alpine debug to testing * Fix whitespace * Update dependencies from https://github.com/dotnet/aspnetcore build 20200305.1 (#877) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.2.20155.1 * Update build.yml to use OSX 10.14 (#874) * Update build.yml * try xcode version 9.4.1 * Try 10.3 * Fix print statements in lldbhelper.py * PR feedback * try to fix build * Add symbol publishing property to disable the special indexing (#888) Fixes the "DUP" errors in the symbol publishing stage. * Update dependencies from https://github.com/dotnet/arcade build 20200308.2 (#890) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20158.2 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20158.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Create dotnet-monitor tool (#878) * Create dotnet-monitor tool * Listens for TraceEvent for logging and metrics. * Currently supports a console sink, and a Log Analytics metric sink * Designed to be used in an Aks sidecar to produce logging/metrics. * bump trace event version to be able to use new file format * handle the new file format * [master] Update dependencies from dotnet/runtime (#876) * Update dependencies from https://github.com/dotnet/runtime build 20200304.1 - Microsoft.NETCore.App - 5.0.0-preview.2.20154.1 * Update dependencies from https://github.com/dotnet/runtime build 20200305.1 - Microsoft.NETCore.App - 5.0.0-preview.2.20155.1 * Update dependencies from https://github.com/dotnet/runtime build 20200305.3 - Microsoft.NETCore.App - 5.0.0-preview.2.20155.3 * Update dependencies from https://github.com/dotnet/runtime build 20200309.13 - Microsoft.NETCore.App - 5.0.0-preview.3.20159.13 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [master] Update dependencies from dotnet/aspnetcore (#886) * Update dependencies from https://github.com/dotnet/aspnetcore build 20200306.9 - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20156.9 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200307.4 - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20157.4 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200308.5 - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20158.5 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200309.15 - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20159.15 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Fix several issues in build and publishing (#889) * Make packages explicitly Shipping/Non-Shipping * Work around SDK bug that trips sourcelink validation * Cleanup properies in publishing These properties used to be needed, but they have been removed in arcade. The new workflow is to use pipeline publishing which this repo uses. * Make publishing explicit for test products that need it This will save us from hardcoding paths by making it more explicit. That way when we clean up and decouple builds we can have breaks when needed. It also brings down artifact size from 318 MB to 206 for xcopy tests needed for helix. * Correctly bubble up native build issues. * Change dotnet-monitor tool to non-shipping temporarily (#891) * Revert "[master] Update dependencies from dotnet/aspnetcore (#886)" (#897) This reverts commit ee8ed8048c825db6af021dc794e3ecc0d649df03. This version of the AspNetCore runtime still works against a busted version of the runtime. * Add darc dependency to symstore (#898) * Update versions of older runtimes to test * Add symstore dependency for automated dependency flow * Update dependencies from https://github.com/dotnet/arcade build 20200310.4 (#899) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20160.4 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20160.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/symstore build 20200309.4 (#900) - Microsoft.SymbolStore - 1.0.115904 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * install latest version of System.Runtime.CompilerServices.Unsafe to avoid "Could not load file or assembly” error * Update dependencies from https://github.com/dotnet/runtime build 20200310.8 (#901) - Microsoft.NETCore.App - 5.0.0-preview.3.20160.8 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * update TraceEvent and revert the workaround * Change the "dotnet-dump collect" default to "full" dumps. (#903) The new "full" dump collection type includes all the module images on both Windows and Linux. The old default type "Heap" is still the same and can be used if the dump is too big. Full dumps are roughly 1.5 times bigger on Windows and 30% bigger on Linux for a simple webapp. Issue: https://github.com/dotnet/diagnostics/issues/808 * Update dependencies from https://github.com/dotnet/runtime build 20200311.9 (#904) - Microsoft.NETCore.App - 5.0.0-preview.3.20161.9 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Remove checking for python (#906) * Update dependencies from https://github.com/dotnet/symstore build 20200313.2 (#916) - Microsoft.SymbolStore - 1.0.116302 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update diagnostics-client-library-instructions.md (#917) Missing semicolon. Excited to see this documentation :) * Add .NET Core hosting location file support (#915) * Add .NET Core hosting location file support Look for the /etc/dotnet/install_location file on Linux/MacOS for the .NET Core runtime to host SOS's managed code. Didn't add the check for Windows registry key at this time because we may switch to the desktop CLR as the host. Issue #https://github.com/dotnet/diagnostics/issues/882 Add 5.0 to the list of hosting runtime versions. * Code review feedback * Update to clrmd 1.1.116301 (#918) * Update dependencies from https://github.com/dotnet/arcade build 20200312.3 (#919) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20162.3 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20162.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/symstore build 20200316.1 (#922) - Microsoft.SymbolStore - 1.0.116601 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Fix coreclr paths to match new runtime repo (#923) * [dotnet-dump] Allow Linux core dumps to be loaded on WIndows (#927) * [dotnet-dump] Allow Linux core dumps to be loaded on WIndows * Respond to feedback * Fix dotnet-dump analyze <dump-path> -c exit (#924) * Fix dotnet-dump analyze <dump-path> -c exit The exit command would fail to exit the analyze process when executed from the command line. * Move fix to ConsoleProvider per feedback, simplify * Fix cross-dac Runtime::CreateInstance() (#928) * Fix LoadNativeSymbols for cross-dac (#929) * Update NuGet.configto include dotnet5, eng, and tools feeds (#932) * [master] Update dependencies from dotnet/aspnetcore (#902) * Update dependencies from https://github.com/dotnet/aspnetcore build 20200310.1 - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20160.1 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200311.8 - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20161.8 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200312.5 - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20162.5 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200314.1 - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20164.1 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200314.4 - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20164.4 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200317.1 - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20167.1 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200318.5 - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20168.5 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200320.1 - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20170.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Disable Microsoft.Diagnostics.NETCore.Client.WriteAllDumpTypesTest (#934) Given dotnet/diagnostics#913 I'm disabling this test until it can get investigated. This path is exerted in @d366deb src/Tools/dotnet-dump/Dumper.cs:77 and dotnet-dump has several tests for collecting dump types, so even if we disable the test, we will still get some coverage. * [master] Update dependencies from dotnet/runtime (#925) * Update dependencies from https://github.com/dotnet/runtime build 20200317.12 - Microsoft.NETCore.App - 5.0.0-preview.3.20167.12 * Update dependencies from https://github.com/dotnet/runtime build 20200318.9 - Microsoft.NETCore.App - 5.0.0-preview.3.20168.9 * Update dependencies from https://github.com/dotnet/runtime build 20200319.13 - Microsoft.NETCore.App - 5.0.0-preview.3.20169.13 * Update dependencies from https://github.com/dotnet/runtime build 20200320.8 - Microsoft.NETCore.App - 5.0.0-preview.3.20170.8 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/aspnetcore build 20200321.1 (#935) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20171.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/runtime build 20200321.6 (#937) - Microsoft.NETCore.App - 5.0.0-preview.3.20171.6 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/runtime build 20200322.1 (#939) - Microsoft.NETCore.App - 5.0.0-preview.3.20172.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20200321.1 (#938) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20171.1 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20171.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Fix Runtime::GetRuntime*Name() for cross-dac (#930) * Fix Runtime::GetRuntime*Name() for cross-dac * Refactor GetRuntime*Name() Add IRuntime::RuntimeConfiguration Add IRuntime::GetRuntimeConfiguration() Remove IRuntime::IsDesktop() Remove NETCORE_RUNTIME* Remove DESKTOP_RUNTIME* * Fix dotnet-dump analyze clrmd CreateRuntime (#940) * Update dependencies from https://github.com/dotnet/runtime build 20200324.1 (#945) - Microsoft.NETCore.App - 5.0.0-preview.3.20174.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/aspnetcore build 20200323.4 (#946) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20173.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * dotnet-dump analyze dso (#944) Fix dso for cross dac case * Update dependencies from https://github.com/dotnet/symstore build 20200323.1 (#947) - Microsoft.SymbolStore - 1.0.117301 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * dotnet-dump analyze clrthreads -special (#943) * dotnet-dump analyze clrthreads -special Detect support at runtime * Add ONLY_SUPPORTED_ON_WINDOWS_TARGET() (#948) Some commands are not included in Linux support. Add ONLY_SUPPORTED_ON_WINDOWS_TARGET() to disable these commands when working with Linux dumps on Windows. * Mark more APIs ONLY_SUPPORTED_ON_WINDOWS_TARGET (#949) * Mark more APIs ONLY_SUPPORTED_ON_WINDOWS_TARGET Mark all commands not reachable from Linux LLVM or dotnet-dump analyze on Linux ONLY_SUPPORTED_ON_WINDOWS_TARGET * Support testing internal service releases (#926) Support testing internal service releases Adds 3 pipeline variables that need to be set testing an internal service release: InternalRuntimeSourceVersion - the service release version i.e. 2.1.17, 3.1.3, etc. InternalRuntimeSourceFeed - the service release internal feed InternalRuntimeSourceFeedKey - the service release feed PAT No longer runs the tests on desktop framework if private build or internal service release. Remove dailytest option * Add IsWindowsTarget() (#951) * Add IsWindowsTarget() Add runtime logic to disable Windows only code when diagnosing Linux dumps on Windows * Update dependencies from https://github.com/dotnet/runtime build 20200324.7 (#952) - Microsoft.NETCore.App - 5.0.0-preview.3.20174.7 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/aspnetcore build 20200324.9 (#953) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20174.9 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * dotnet-dump analyze enable cross DAC lookup (#954) * Fix SOSHost.IsCoreClrRuntimeModule() * Fix cross DAC LoadNativeSymbols() This allows the SOSHost to find the cross DAC in the symbol cache * Feedback When creating a SymbolStoreKey semi-clone copy all the fields * Update dependencies from https://github.com/dotnet/aspnetcore build 20200325.16 (#957) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20175.16 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/symstore build 20200325.1 (#958) - Microsoft.SymbolStore - 1.0.117501 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [master] Update dependencies from dotnet/runtime (#956) * Update dependencies from https://github.com/dotnet/runtime build 20200325.10 - Microsoft.NETCore.App - 5.0.0-preview.3.20175.10 * Update dependencies from https://github.com/dotnet/runtime build 20200326.12 - Microsoft.NETCore.App - 5.0.0-preview.3.20176.12 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update core dump debugging workflow (#962) * Update dependencies from https://github.com/dotnet/runtime build 20200328.1 (#963) - Microsoft.NETCore.App - 5.0.0-preview.3.20178.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [master] Update dependencies from dotnet/aspnetcore (#960) * Update dependencies from https://github.com/dotnet/aspnetcore build 20200326.15 - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20176.15 * Update dependencies from https://github.com/dotnet/aspnetcore build 20200327.8 - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20177.8 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/runtime build 20200329.1 (#964) - Microsoft.NETCore.App - 5.0.0-preview.3.20179.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/aspnetcore build 20200328.11 (#965) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20178.11 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dotnet-tools.md * Update dotnet-tools.md * Update dependencies from https://github.com/dotnet/runtime build 20200330.1 (#967) - Microsoft.NETCore.App - 5.0.0-preview.3.20180.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/aspnetcore build 20200329.3 (#968) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.3.20179.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Fix some misc SOS issues (#966) * Display some more MT info * Issue https://github.com/dotnet/diagnostics/issues/816 * Issue https://github.com/dotnet/diagnostics/issues/941 * Issue https://github.com/dotnet/diagnostics/issues/942 * Fix sosstatus runtime size display * Update dependencies from https://github.com/dotnet/runtime build 20200330.15 (#969) - Microsoft.NETCore.App - 5.0.0-preview.3.20180.15 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/aspnetcore build 20200330.11 (#970) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.4.20180.11 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/aspnetcore build 20200331.16 (#972) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.4.20181.16 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/runtime build 20200401.1 (#971) - Microsoft.NETCore.App - 5.0.0-preview.4.20201.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Report missing DAC error for cross DAC clrstack -i (#973) * Report missing DAC error for cross DAC clrstack -i * Feedback * Report stack walk failures (#975) * Fix description list command (#974) * cleanup unused field, fix description of GC collection counts in list command * Fix build * Update dependencies from https://github.com/dotnet/runtime build 20200401.19 (#977) - Microsoft.NETCore.App - 5.0.0-preview.4.20201.19 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/aspnetcore build 20200401.16 (#978) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.4.20201.16 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Link Code of Conduct (#980) * Update dependencies from https://github.com/dotnet/runtime build 20200402.18 (#981) - Microsoft.NETCore.App - 5.0.0-preview.4.20202.18 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/aspnetcore build 20200402.13 (#982) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.4.20202.13 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/runtime build 20200404.1 (#984) - Microsoft.NETCore.App - 5.0.0-preview.4.20204.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/symstore build 20200403.1 (#986) - Microsoft.SymbolStore - 1.0.120301 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/aspnetcore build 20200403.11 (#985) - Microsoft.AspNetCore.App.Ref - 5.0.0-preview.4.20203.11 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Filter the tools' own PID out of ps command result (#983) * Update dependencies from https://github.com/dotnet/runtime build 20200404.15 (#988) - Microsoft.NETCore.App - 5.0.0-preview.4.20204.15 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20200401.2 (#989) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20201.2 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20201.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/runtime build 20200405.13 (#990) - Microsoft.NETCore.App - 5.0.0-preview.4.20205.13 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Remove dotnet-counters' unnecessary dependencies (#992) Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Sung Yoon Whang <suwhang@microsoft.com> Co-authored-by: Paul Harrington <pharring@users.noreply.github.com> Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com> Co-authored-by: jiangzeng01 <49379637+jiangzeng01@users.noreply.github.com> Co-authored-by: Sean-Driscoll <42188295+Sean-Driscoll@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: Andrew Au <andrewau@microsoft.com> Co-authored-by: Dongkyun Son <tenblood@gmail.com> Co-authored-by: Omair Majid <omajid@redhat.com> Co-authored-by: Andy Sterland <andster@microsoft.com> Co-authored-by: Koundinya Veluri <kouvel@users.noreply.github.com> Co-authored-by: Next Turn <45985406+NextTurn@users.noreply.github.com> Co-authored-by: Ilia <ki.stfu@gmail.com> Co-authored-by: Mohammad Mustakim Ali <mustakimali@hotmail.com> Co-authored-by: Mikhail Kurinnoi <viewizard@viewizard.com> Co-authored-by: dotnet-bot <dotnet-bot@microsoft.com> Co-authored-by: Juan Hoyos <juan.hoyos@microsoft.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Wiktor Kopec <wiktork@microsoft.com> Co-authored-by: John Salem <josalem@microsoft.com> Co-authored-by: Mike Murkovic <mike.murko@gmail.com> Co-authored-by: Steve MacLean <Steve.MacLean@microsoft.com> Co-authored-by: Mohammad Mustakim Ali <mustakimali@users.noreply.github.com> Co-authored-by: Immo Landwerth <immol@microsoft.com>

sywhang added 17 commits November 5, 2019 18:45

First batch of files

22030df

Make dotnet-counters use the diagnostics client library

3fde2a7

Port dotnet-trace

d9efaff

Port dotnet-dump

13c8306

Implement WriteDump

f8667ff

Implement AttachProfiler

54b78a6

Implement GetPublishedProcesses

fa48772

Implement dispose overrides

9c8dc4d

Port dotnet-gcdump

614ba31

Port dotnet-trace tests

142e938

Default keyword is not ulong.max

e22532d

Fix argument parser

45886f1

Merge remote-tracking branch 'upstream/master' into dev/suwhang/rcl-i…

4dec226

…mplementation

Add diagnostics client library to diagnostics solution

ccd1c17

Fix few bugs, start throwing relevant exceptions

46f0402

Add more exception throws

31aaa2a

Undo accidental change

3b51ff0

mikem8361 reviewed Nov 14, 2019

View reviewed changes

src/Tools/dotnet-dump/Dumper.cs Show resolved Hide resolved

mikem8361 reviewed Nov 14, 2019

View reviewed changes

src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/DiagnosticsClient.cs Outdated Show resolved Hide resolved

sywhang added 11 commits November 14, 2019 15:55

Fix build error, address PR feedback

f087d15

remove TODO and add asserts on header parse

0642cad

Add exception handling for counters

a0b3c57

Add exception handling for dotnet-trace

1a47b41

Fix default keyword not being all fs when no keyword specified

48333bd

Add test for DiagnosticsClient library

bec51df

Remove unused regex

5151b30

Add TestHelpers to DiagnosticsClient test

d3cf367

Added test runner, GetPublishedProcesses tests

6fc7fb3

Fix test run on Linux

488e137

Add Tracee

3697a54

sywhang added 2 commits November 26, 2019 13:01

Merge with master

44e1163

Fix build

17eff82

WojciechNagorski mentioned this pull request Nov 27, 2019

Implement Unix Disassembler for .NET Core dotnet/BenchmarkDotNet#1316

Closed

noahfalk approved these changes Nov 27, 2019

View reviewed changes

WojciechNagorski mentioned this pull request Nov 27, 2019

The EventPipeProfiler cross-platform profiler dotnet/BenchmarkDotNet#1321

Merged