fix: filter compiler generated helpers (#9489)

dotnet · Nov 29, 2023 · 50b064a · 50b064a
1 parent 476a2a3
commit 50b064a
Show file tree

Hide file tree

Showing 63 changed files with 6,906 additions and 3,975 deletions.
diff --git a/samples/seed/dotnet/assembly/BuildFromAssembly.csproj b/samples/seed/dotnet/assembly/BuildFromAssembly.csproj
@@ -5,6 +5,7 @@
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
+    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/samples/seed/dotnet/assembly/Class1.cs b/samples/seed/dotnet/assembly/Class1.cs
@@ -18,3 +18,19 @@ public static void HelloWorld() { }
     [EditorBrowsable(EditorBrowsableState.Never)]
     public void HiddenAPI() { }
 }
+
+public unsafe struct Issue5432
+{
+    private fixed char Name0[30];
+
+    public string Name
+    {
+        get
+        {
+            fixed (char* name = Name0)
+            {
+                return new string((char*)name);
+            }
+        }
+    }
+}
diff --git a/src/Docfx.Dotnet/SymbolFilter.cs b/src/Docfx.Dotnet/SymbolFilter.cs
@@ -26,7 +26,7 @@ public SymbolFilter(ExtractMetadataConfig config, DotnetApiOptions options)
 
     public bool IncludeApi(ISymbol symbol)
     {
-        return IsSymbolAccessible(symbol) && IncludeApiCore(symbol);
+        return !IsCompilerGeneratedDisplayClass(symbol) && IsSymbolAccessible(symbol) && IncludeApiCore(symbol);
 
         bool IncludeApiCore(ISymbol symbol)
         {
@@ -45,6 +45,11 @@ bool IncludeApiDefault(ISymbol symbol)
 
             return symbol.ContainingSymbol is null || IncludeApiCore(symbol.ContainingSymbol);
         }
+
+        static bool IsCompilerGeneratedDisplayClass(ISymbol symbol)
+        {
+            return symbol.Kind == SymbolKind.NamedType && (symbol.Name.Contains('<') || symbol.Name.Contains('>'));
+        }
     }
 
     public bool IncludeAttribute(ISymbol symbol)