chore: suppress IDE0044 message

src/Docfx.App/Config/FileMetadataPairs.cs

@@ -15,7 +15,7 @@ namespace Docfx;
 internal class FileMetadataPairs
 {
     // Order matters, the latter one overrides the former one
-    private List<FileMetadataPairsItem> _items;
+    private readonly List<FileMetadataPairsItem> _items;
 
     /// <summary>
     /// Gets FileMetadataPairs items.

src/Docfx.Build.Common/ModelAttributeHandlers/Handlers/BaseModelAttributeHandler.cs

@@ -10,7 +10,7 @@ public abstract class BaseModelAttributeHandler<T> : IModelAttributeHandler wher
     private const int MaximumNestedLevel = 32;
     private readonly TypeInfo _typeInfo;
     protected readonly IModelAttributeHandler Handler;
-    private Type _type;
+    private readonly Type _type;
     protected BaseModelAttributeHandler(Type type, IModelAttributeHandler handler)
     {
         ArgumentNullException.ThrowIfNull(type);

src/Docfx.Build.Common/ModelAttributeHandlers/Handlers/CompositeModelAttributeHandler.cs

@@ -5,7 +5,7 @@ namespace Docfx.Build.Common;
 
 public class CompositeModelAttributeHandler : IModelAttributeHandler
 {
-    private IModelAttributeHandler[] _handlers;
+    private readonly IModelAttributeHandler[] _handlers;
     public CompositeModelAttributeHandler(params IModelAttributeHandler[] handlers)
     {
         _handlers = handlers;

src/Docfx.Build.Engine/HostServiceCreator.cs

@@ -11,7 +11,7 @@ namespace Docfx.Build.Engine;
 
 internal class HostServiceCreator : IHostServiceCreator
 {
-    private DocumentBuildContext _context;
+    private readonly DocumentBuildContext _context;
 
     public HostServiceCreator(DocumentBuildContext context)
     {

src/Docfx.Build.Engine/PostProcessors/PostProcessorsManager.cs

@@ -12,7 +12,7 @@ namespace Docfx.Build.Engine;
 internal class PostProcessorsManager : IDisposable
 {
     private readonly List<PostProcessor> _postProcessors;
-    private IPostProcessorsHandler _postProcessorsHandler;
+    private readonly IPostProcessorsHandler _postProcessorsHandler;
 
     public PostProcessorsManager(CompositionHost container, ImmutableArray<string> postProcessorNames)
     {

src/Docfx.Build.Engine/PostProcessors/ValidateBookmark.cs

@@ -23,7 +23,7 @@ public sealed class ValidateBookmark : HtmlDocumentHandler
     /// </summary>
     private readonly OSPlatformSensitiveDictionary<string> _fileMapping =
         new();
-    private OSPlatformSensitiveDictionary<List<LinkItem>> _linksWithBookmark =
+    private readonly OSPlatformSensitiveDictionary<List<LinkItem>> _linksWithBookmark =
         new();
 
     #region IHtmlDocumentHandler members

src/Docfx.Build.Engine/ResourceFileReaders/LocalFileResourceReader.cs

@@ -9,8 +9,8 @@ public sealed class LocalFileResourceReader : ResourceFileReader
 {
     private const int MaxSearchLevel = 5;
     // keep comparer to be case sensitive as to be consistent with zip entries
-    private static StringComparer ResourceComparer = StringComparer.Ordinal;
-    private string _directory = null;
+    private static readonly StringComparer ResourceComparer = StringComparer.Ordinal;
+    private readonly string _directory = null;
     private readonly int _maxDepth;
     private readonly HashSet<string> NamesHashSet;
 

src/Docfx.Build.Engine/TemplateProcessors/TemplateCollection.cs

@@ -5,7 +5,7 @@ namespace Docfx.Build.Engine;
 
 public class TemplateCollection : Dictionary<string, TemplateBundle>
 {
-    private TemplateBundle _defaultTemplate = null;
+    private readonly TemplateBundle _defaultTemplate = null;
 
     public IResourceFileReader Reader { get; }
 

src/Docfx.Build.ManagedReference/FillReferenceInformation.cs

@@ -14,7 +14,7 @@ namespace Docfx.Build.ManagedReference;
 [Export(nameof(ManagedReferenceDocumentProcessor), typeof(IDocumentBuildStep))]
 public class FillReferenceInformation : BaseDocumentBuildStep
 {
-    private Dictionary<string, SourceInfo> _items = new();
+    private readonly Dictionary<string, SourceInfo> _items = new();
 
     public override string Name => nameof(FillReferenceInformation);
 

src/Docfx.Build.OverwriteDocuments/MarkdownFragmentsCreator.cs

@@ -20,13 +20,13 @@ public class MarkdownFragmentsCreator
 
     private int _position;
 
-    private InlineCodeHeadingRule _inlineCodeHeadingRule = new();
+    private readonly InlineCodeHeadingRule _inlineCodeHeadingRule = new();
 
-    private L1InlineCodeHeadingRule _l1InlineCodeHeadingRule = new();
+    private readonly L1InlineCodeHeadingRule _l1InlineCodeHeadingRule = new();
 
-    private L2InlineCodeHeadingRule _l2InlineCodeHeadingRule = new();
+    private readonly L2InlineCodeHeadingRule _l2InlineCodeHeadingRule = new();
 
-    private YamlCodeBlockRule _yamlCodeBlockRule = new();
+    private readonly YamlCodeBlockRule _yamlCodeBlockRule = new();
 
     public IEnumerable<MarkdownFragmentModel> Create(MarkdownDocument document)
     {

src/Docfx.Build.OverwriteDocuments/OverwriteDocumentModelCreator.cs

@@ -9,7 +9,7 @@ namespace Docfx.Build.OverwriteDocuments;
 
 public class OverwriteDocumentModelCreator
 {
-    string _file;
+    private readonly string _file;
 
     public OverwriteDocumentModelCreator(string file)
     {

src/Docfx.Build.SchemaDriven/ValidateFragmentsHandler.cs

@@ -10,7 +10,7 @@ namespace Docfx.Build.SchemaDriven;
 
 public class ValidateFragmentsHandler : ISchemaFragmentsHandler
 {
-    Dictionary<string, bool> _isMissingUidsLogged = new();
+    private readonly Dictionary<string, bool> _isMissingUidsLogged = new();
 
     public void HandleUid(string uidKey, YamlMappingNode node, Dictionary<string, MarkdownFragment> fragments, BaseSchema schema, string oPathPrefix, string uid)
     {

src/Docfx.Common/FileItems.cs

@@ -6,7 +6,7 @@ namespace Docfx;
 [Serializable]
 public class FileItems : List<string>
 {
-    private static IEnumerable<string> Empty = new List<string>();
+    private static readonly IEnumerable<string> Empty = new List<string>();
     public FileItems(string file) : base()
     {
         Add(file);

src/Docfx.Common/FileMapping.cs

@@ -30,7 +30,7 @@ namespace Docfx;
 [Serializable]
 public class FileMapping
 {
-    private List<FileMappingItem> _items = new();
+    private readonly List<FileMappingItem> _items = new();
 
     /// <summary>
     /// Flags to distinguish items are expanded or not.

src/Docfx.Dotnet/SymbolFormatter.Syntax.cs

@@ -57,7 +57,7 @@ class SyntaxFormatter
         public SyntaxLanguage Language { get; init; }
         public SymbolFilter Filter { get; init; } = default!;
 
-        private ImmutableArray<SymbolDisplayPart>.Builder _parts = ImmutableArray.CreateBuilder<SymbolDisplayPart>();
+        private readonly ImmutableArray<SymbolDisplayPart>.Builder _parts = ImmutableArray.CreateBuilder<SymbolDisplayPart>();
 
         public ImmutableArray<SymbolDisplayPart> GetSyntax(ISymbol symbol)
         {

src/Docfx.Glob/GlobMatcher.cs

@@ -40,9 +40,9 @@ public class GlobMatcher : IEquatable<GlobMatcher>
 
     private static readonly Regex GlobStarRegex = new(@"^\*{2,}/?$", RegexOptions.Compiled);
 
-    private GlobRegexItem[][] _items;
-    private bool _negate = false;
-    private bool _ignoreCase = false;
+    private readonly GlobRegexItem[][] _items;
+    private readonly bool _negate = false;
+    private readonly bool _ignoreCase = false;
     #endregion
 
     public const GlobMatcherOptions DefaultOptions = GlobMatcherOptions.AllowNegate | GlobMatcherOptions.IgnoreCase | GlobMatcherOptions.AllowGlobStar | GlobMatcherOptions.AllowExpand | GlobMatcherOptions.AllowEscape;

src/Docfx.MarkdigEngine.Extensions/Aggregator/BlockAggregateContext.cs

@@ -7,7 +7,7 @@ namespace Docfx.MarkdigEngine.Extensions;
 
 public class BlockAggregateContext
 {
-    private ContainerBlock _blocks;
+    private readonly ContainerBlock _blocks;
     private int _currentBlockIndex = -1;
 
     public BlockAggregateContext(ContainerBlock blocks)

src/Docfx.MarkdigEngine.Extensions/Inclusion/InclusionBlock/HtmlInclusionBlockRenderer.cs

@@ -10,7 +10,7 @@ namespace Docfx.MarkdigEngine.Extensions;
 public class HtmlInclusionBlockRenderer : HtmlObjectRenderer<InclusionBlock>
 {
     private readonly MarkdownContext _context;
-    private MarkdownPipeline _pipeline;
+    private readonly MarkdownPipeline _pipeline;
 
     public HtmlInclusionBlockRenderer(MarkdownContext context, MarkdownPipeline pipeline)
     {

src/Docfx.MarkdigEngine.Extensions/TabGroup/ActiveAndVisibleRewriter.cs

@@ -10,7 +10,7 @@ namespace Docfx.MarkdigEngine.Extensions;
 public class ActiveAndVisibleRewriter : IMarkdownObjectRewriter
 {
     private readonly MarkdownContext _context;
-    private List<string[]> tabSelectionInfo = new();
+    private readonly List<string[]> tabSelectionInfo = new();
 
     public ActiveAndVisibleRewriter(MarkdownContext context)
     {

src/Docfx.Plugins/TreeNavigator.cs

@@ -5,7 +5,7 @@ namespace Docfx.Plugins;
 
 public class TreeNavigator
 {
-    private NavigatorTreeItem _tree;
+    private readonly NavigatorTreeItem _tree;
     private NavigatorTreeItem _current;
 
     public TreeNavigator(TreeItem tree)

src/Docfx.YamlSerialization/NodeDeserializers/EmitArrayNodeDeserializer.cs

@@ -12,7 +12,7 @@ namespace Docfx.YamlSerialization.NodeDeserializers;
 
 public class EmitArrayNodeDeserializer : INodeDeserializer
 {
-    private static MethodInfo DeserializeHelperMethod =
+    private static readonly MethodInfo DeserializeHelperMethod =
         typeof(EmitArrayNodeDeserializer).GetMethod(nameof(DeserializeHelper));
     private static readonly ConcurrentDictionary<Type, Func<IParser, Type, Func<IParser, Type, object>, object>> _funcCache =
         new();

src/Docfx.YamlSerialization/ObjectGraphTraversalStrategies/FullObjectGraphTraversalStrategy.cs

@@ -27,7 +27,7 @@ public class FullObjectGraphTraversalStrategy : IObjectGraphTraversalStrategy
     private readonly int _maxRecursion;
     private readonly ITypeInspector _typeDescriptor;
     private readonly ITypeResolver _typeResolver;
-    private INamingConvention _namingConvention;
+    private readonly INamingConvention _namingConvention;
     private readonly Dictionary<Tuple<Type, Type>, Action<IObjectDescriptor, IObjectGraphVisitor, int, IObjectGraphVisitorContext>> _behaviorCache =
         new();
     private readonly Dictionary<Tuple<Type, Type, Type>, Action<FullObjectGraphTraversalStrategy, object, IObjectGraphVisitor, int, INamingConvention, IObjectGraphVisitorContext>> _traverseGenericDictionaryCache =

src/docfx/Models/InitCommand.cs

@@ -364,7 +364,7 @@ private static bool Converter(string input)
 
     private class SingleChoiceQuestion<T> : Question<T>
     {
-        private Func<string, T> _converter;
+        private readonly Func<string, T> _converter;
         /// <summary>
         /// Options, the first one as the default one
         /// </summary>

test/Docfx.Build.ConceptualDocuments.Tests/ConceptualDocumentProcessorTest.cs

@@ -22,8 +22,8 @@ public class ConceptualDocumentProcessorTest : TestBase
     private readonly string _templateFolder;
     private readonly FileCollection _defaultFiles;
     private readonly FileCreator _fileCreator;
-    private ApplyTemplateSettings _applyTemplateSettings;
-    private TemplateManager _templateManager;
+    private readonly ApplyTemplateSettings _applyTemplateSettings;
+    private readonly TemplateManager _templateManager;
     private const string RawModelFileExtension = ".raw.json";
 
     public ConceptualDocumentProcessorTest()

test/Docfx.Build.Engine.Tests/ExtractSearchIndexFromHtmlTest.cs

@@ -11,7 +11,7 @@ namespace Docfx.Build.Engine.Tests;
 [Collection("docfx STA")]
 public class ExtractSearchIndexFromHtmlTest
 {
-    private static ExtractSearchIndex _extractor = new();
+    private static readonly ExtractSearchIndex _extractor = new();
 
     [Fact]
     public void TestBasicFeature()

test/Docfx.Build.Engine.Tests/ValidateBookmarkTest.cs

@@ -13,7 +13,7 @@ namespace Docfx.Build.Engine.Tests;
 public class ValidateBookmarkTest : TestBase
 {
     private readonly string _outputFolder;
-    private TestLoggerListener _listener = TestLoggerListener.CreateLoggerListenerWithPhaseEqualFilter("validate_bookmark.ValidateBookmark");
+    private readonly TestLoggerListener _listener = TestLoggerListener.CreateLoggerListenerWithPhaseEqualFilter("validate_bookmark.ValidateBookmark");
 
     public ValidateBookmarkTest()
     {

test/Docfx.Build.ManagedReference.Tests/ManagedReferenceDocumentProcessorTest.cs

@@ -17,11 +17,11 @@ namespace Docfx.Build.ManagedReference.Tests;
 
 public class ManagedReferenceDocumentProcessorTest : TestBase
 {
-    private string _outputFolder;
-    private string _inputFolder;
-    private FileCollection _defaultFiles;
-    private ApplyTemplateSettings _applyTemplateSettings;
-    private TemplateManager _templateManager;
+    private readonly string _outputFolder;
+    private readonly string _inputFolder;
+    private readonly FileCollection _defaultFiles;
+    private readonly ApplyTemplateSettings _applyTemplateSettings;
+    private readonly TemplateManager _templateManager;
 
     private const string RawModelFileExtension = ".raw.json";
     private const string MrefDirectory = "mref";

test/Docfx.Build.OverwriteDocuments.Tests/OverwriteDocumentModelCreatorTest.cs

@@ -12,7 +12,7 @@ namespace Docfx.Build.OverwriteDocuments.Tests;
 
 public class OverwriteDocumentModelCreatorTest
 {
-    private TestLoggerListener _listener = TestLoggerListener.CreateLoggerListenerWithPhaseEqualFilter("overwrite_document_model_creator");
+    private readonly TestLoggerListener _listener = TestLoggerListener.CreateLoggerListenerWithPhaseEqualFilter("overwrite_document_model_creator");
 
     [Fact]
     public void YamlCodeBlockTest()

test/Docfx.Build.RestApi.Tests/RestApiDocumentProcessorTest.cs

@@ -18,10 +18,10 @@ namespace Docfx.Build.RestApi.Tests;
 [Collection("docfx STA")]
 public class RestApiDocumentProcessorTest : TestBase
 {
-    private string _outputFolder;
-    private string _inputFolder;
-    private FileCollection _defaultFiles;
-    private ApplyTemplateSettings _applyTemplateSettings;
+    private readonly string _outputFolder;
+    private readonly string _inputFolder;
+    private readonly FileCollection _defaultFiles;
+    private readonly ApplyTemplateSettings _applyTemplateSettings;
 
     private const string RawModelFileExtension = ".raw.json";
     private const string SwaggerDirectory = "swagger";

test/Docfx.Build.RestApi.WithPlugins.Tests/SplitRestApiToOperationLevelTest.cs

@@ -19,11 +19,11 @@ namespace Docfx.Build.RestApi.WithPlugins.Tests;
 [Collection("docfx STA")]
 public class SplitRestApiToOperationLevelTest : TestBase
 {
-    private string _inputFolder;
-    private string _outputFolder;
-    private FileCollection _defaultFiles;
+    private readonly string _inputFolder;
+    private readonly string _outputFolder;
+    private readonly FileCollection _defaultFiles;
     private readonly ApplyTemplateSettings _applyTemplateSettings;
-    private TemplateManager _templateManager;
+    private readonly TemplateManager _templateManager;
 
     private const string RawModelFileExtension = ".raw.json";
 

test/Docfx.Build.RestApi.WithPlugins.Tests/SplitRestApiToTagLevelTest.cs

@@ -20,11 +20,11 @@ namespace Docfx.Build.RestApi.WithPlugins.Tests;
 [Collection("docfx STA")]
 public class SplitRestApiToTagLevelTest : TestBase
 {
-    private string _inputFolder;
-    private string _outputFolder;
-    private FileCollection _defaultFiles;
+    private readonly string _inputFolder;
+    private readonly string _outputFolder;
+    private readonly FileCollection _defaultFiles;
     private readonly ApplyTemplateSettings _applyTemplateSettings;
-    private TemplateManager _templateManager;
+    private readonly TemplateManager _templateManager;
 
     private const string RawModelFileExtension = ".raw.json";
 

test/Docfx.Build.SchemaDriven.Tests/LimitationReachedTest.cs

@@ -14,15 +14,15 @@ namespace Docfx.Build.SchemaDriven.Tests;
 [Collection("docfx STA")]
 public class LimitationReachedTest : TestBase
 {
-    private static Regex InputMatcher = new(@"```(yml|yaml)\s*(### YamlMime:[\s\S]*?)\s*```", RegexOptions.Compiled | RegexOptions.IgnoreCase);
-    private static Regex SchemaMatcher = new(@"```json\s*(\{\s*""\$schema""[\s\S]*?)\s*```", RegexOptions.Compiled | RegexOptions.IgnoreCase);
+    private static readonly Regex InputMatcher = new(@"```(yml|yaml)\s*(### YamlMime:[\s\S]*?)\s*```", RegexOptions.Compiled | RegexOptions.IgnoreCase);
+    private static readonly Regex SchemaMatcher = new(@"```json\s*(\{\s*""\$schema""[\s\S]*?)\s*```", RegexOptions.Compiled | RegexOptions.IgnoreCase);
 
-    private string _outputFolder;
-    private string _inputFolder;
-    private string _templateFolder;
-    private FileCollection _defaultFiles;
-    private ApplyTemplateSettings _applyTemplateSettings;
-    private TemplateManager _templateManager;
+    private readonly string _outputFolder;
+    private readonly string _inputFolder;
+    private readonly string _templateFolder;
+    private readonly FileCollection _defaultFiles;
+    private readonly ApplyTemplateSettings _applyTemplateSettings;
+    private readonly TemplateManager _templateManager;
 
     private const string RawModelFileExtension = ".raw.json";
 

test/Docfx.Build.SchemaDriven.Tests/MergeMarkdownFragmentsTest.cs

@@ -12,16 +12,16 @@ namespace Docfx.Build.SchemaDriven.Tests;
 [Collection("docfx STA")]
 public class MergeMarkdownFragmentsTest : TestBase
 {
-    private string _outputFolder;
-    private string _inputFolder;
-    private string _templateFolder;
-    private FileCollection _defaultFiles;
-    private ApplyTemplateSettings _applyTemplateSettings;
-    private TemplateManager _templateManager;
-    private FileCollection _files;
-
-    private TestLoggerListener _listener;
-    private string _rawModelFilePath;
+    private readonly string _outputFolder;
+    private readonly string _inputFolder;
+    private readonly string _templateFolder;
+    private readonly FileCollection _defaultFiles;
+    private readonly ApplyTemplateSettings _applyTemplateSettings;
+    private readonly TemplateManager _templateManager;
+    private readonly FileCollection _files;
+
+    private readonly TestLoggerListener _listener;
+    private readonly string _rawModelFilePath;
 
     private const string RawModelFileExtension = ".raw.json";
 

test/Docfx.Build.SchemaDriven.Tests/SchemaMergerTest.cs

@@ -16,12 +16,12 @@ namespace Docfx.Build.SchemaDriven.Tests;
 [Collection("docfx STA")]
 public class SchemaMergerTest : TestBase
 {
-    private string _outputFolder;
-    private string _inputFolder;
-    private string _templateFolder;
-    private FileCollection _defaultFiles;
-    private ApplyTemplateSettings _applyTemplateSettings;
-    private TemplateManager _templateManager;
+    private readonly string _outputFolder;
+    private readonly string _inputFolder;
+    private readonly string _templateFolder;
+    private readonly FileCollection _defaultFiles;
+    private readonly ApplyTemplateSettings _applyTemplateSettings;
+    private readonly TemplateManager _templateManager;
 
     private const string RawModelFileExtension = ".raw.json";