Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploded package size and quality concerns #9396

Closed
bkoelman opened this issue Nov 8, 2023 · 2 comments · Fixed by #10066
Closed

Exploded package size and quality concerns #9396

bkoelman opened this issue Nov 8, 2023 · 2 comments · Fixed by #10066
Labels
bug A bug to fix

Comments

@bkoelman
Copy link

bkoelman commented Nov 8, 2023

Package size at https://www.nuget.org/packages/docfx changed from 51 MB to 199 MB since v2.73.0. Is that really needed?

I suspect this is related to the new PDF rendering, which I'm not interested in. However, looking at the output diff, every HTML page now contains the following extra line:

<meta name="loc:downloadPdf" content="Download PDF">

Do you guys ever diff the HTML output with the previous version before release?
Or even run it through an HTML validator? For example, why does every file contain </article> without an opening tag?

I've been getting updates for docfx frequently since I turned on Dependabot updates, but now I'm considering turning that off. It just takes too much time to verify everything and report back. For example, see #9337 (comment) which was supposed to be fixed, but apparently was never tested. I feel like being the beta tester of your product, this is not very professional.

@ipanin
Copy link

ipanin commented Dec 27, 2023

Not only has the package size increased 4 times due to the fact that it includes (and unpacks!) node for all platforms. But it also downloads Chromium and ffmpeg (407 MB on disk) at the first execution of the docx pdf command. Moreover, the download may not be fast, it took me 40 minutes. And if the assembly machine does not have Internet access and it takes all packages from the private Artifactory?

@filzrev
Copy link
Contributor

filzrev commented Apr 12, 2024

docfx package size is increasing constantly.
And it takes 248 MB fir docfx v2.76.0 nupkg.

And extracted files are takes about 1.17GB at following directories.

nupkg extracted files 1.17GB Extracted to %UserProfile%\.nuget\packages\docfx
.NET Global Tool package 1.17 GB Extracted to %UserProfile%\.dotnet\tools\.store\docfx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug to fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants