-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove Node.js runtime dependencies from docfx tools #10066
Merged
yufeih
merged 2 commits into
dotnet:main
from
filzrev:chore-remove-nodejs-runtime-dependencies
Jul 8, 2024
Merged
feat: Remove Node.js runtime dependencies from docfx tools #10066
yufeih
merged 2 commits into
dotnet:main
from
filzrev:chore-remove-nodejs-runtime-dependencies
Jul 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filzrev
changed the title
chore: Remove Node.js runtime dependencies
chore: Remove Node.js runtime dependencies from docfx tools
Jul 5, 2024
filzrev
force-pushed
the
chore-remove-nodejs-runtime-dependencies
branch
from
July 5, 2024 01:41
5e08bf4
to
53ef11f
Compare
yufeih
reviewed
Jul 5, 2024
filzrev
commented
Jul 5, 2024
When using
So I've reverted code to |
filzrev
force-pushed
the
chore-remove-nodejs-runtime-dependencies
branch
from
July 5, 2024 03:44
a32b02f
to
0b7b04b
Compare
yufeih
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @filzrev !
yufeih
added
the
new-feature
Makes the pull request to appear in "New Features" section of the next release note
label
Jul 8, 2024
yufeih
changed the title
chore: Remove Node.js runtime dependencies from docfx tools
feat: Remove Node.js runtime dependencies from docfx tools
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
new-feature
Makes the pull request to appear in "New Features" section of the next release note
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intended to resolve #9396.
Background
Playwright
1.41
or later supports following environment variables. (It's not documented though)PLAYWRIGHT_NODEJS_PATH
PLAYWRIGHT_DRIVER_SEARCH_PATH
So it can remove Node.js runtime from
docfx
package.Instead. it can use locally installed Node.js runtime instead.
By this changes.
docfx
packages size can be reduced from208MB
->56 MB
BREAKING CHANGES
This PR remove
Node.js
runtime bundles.So it may introduce breaking changes for some users who using docfx without Node.js installation.
(e.g. docker image users)
I'll try to fix official docker image later.
https://github.com/dotnet/docfx/blob/main/Dockerfile