Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickable images feature needs a global opt-out in docfx.json #9415

Closed
glopesdev opened this issue Nov 11, 2023 · 0 comments · Fixed by #9416
Closed

Clickable images feature needs a global opt-out in docfx.json #9415

glopesdev opened this issue Nov 11, 2023 · 0 comments · Fixed by #9416
Labels
bug A bug to fix template The stock site template

Comments

@glopesdev
Copy link

glopesdev commented Nov 11, 2023

As described in #8518 (comment).

The introduction of clickable images has been introducing several unpredictable behaviors to our DOM manipulation workflows. I'm not sure I understand the aim of this feature, and having an arbitrary cutoff of 200 pixels and no ability to opt-out is making us have to deal with unexpected edge cases.

Would be great to have a way to opt-out at the level of the docfx.json either with a flag (preferred) or by allowing to specify the value of the pixel cutoff (setting it to None or zero should probably disable the behavior).

@glopesdev glopesdev added the bug A bug to fix label Nov 11, 2023
@yufeih yufeih added the template The stock site template label Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug to fix template The stock site template
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants