feat: add showLightbox option #9416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yufeih
added
the
new-feature
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
yufeih
force-pushed
the
showImageLightbox
branch
from
8b7fc6d
to
a5015a5
Compare
yufeih
changed the title
yufeih
force-pushed
the
showImageLightbox
branch
from
a5015a5
to
7bf840d
Compare
yufeih
added a commit
that referenced
this pull request
Nov 13, 2023
Co-authored-by: Yufei Huang <yufeih@users.noreply.github.com>
p-kostov
pushed a commit
to ErpNetDocs/docfx
that referenced
this pull request
Jun 28, 2024
Co-authored-by: Yufei Huang <yufeih@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
showLightboxconfig inmain.jsthat determines if an image should show as lightbox when clicked. Lightbox currently behaves as opening the image in a new tab, we might change it to an actual lightbox in the future.Fixes #9415