-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redirection document type #8892
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8892 +/- ##
==========================================
+ Coverage 77.00% 77.04% +0.04%
==========================================
Files 605 605
Lines 25036 25040 +4
==========================================
+ Hits 19278 19292 +14
+ Misses 5758 5748 -10
☔ View full report in Codecov by Sentry. |
</head> | ||
</html> | ||
""", result); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify that:
- the generated sitemap does not contain redirections
- the content type in the generated manifest file is redirection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…CRLF/LF) difference
…lzrev/docfx into add-redirection-document-type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, really appreciate all the hard work you put into this! ❤️❤️❤️
Add new DocumentType
Redirection
according to comments on #8821.What's included in this PR
Redirection
document type toDocumentType
.Redirection
. Ifredirect_url
metadata is specified.Redirection.html.primary.tmpl
todefault
build-in template.->
Redirection
documents are processed this Mustache template only. (Don't use_master.tmpl
)SitemapGenerator.cs
to skipRedirection
type documents. and some code refactoring.redirect_url
.Note
_master.tmpl
's conditional statement ({{#redirect_url}}
...{{/redirect_url}}
) are left as is.Because
redirect_url
can be set viaglobal.json
and may effects other DocumentTypes.