Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete warning suppression. and fix deprecated APIs #8937

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Jul 5, 2023

This PR contains following changes.

  • Remove CS0612/CS0618 (Type or member is obsolete) solution-wide warning suppression.
  • Replace deprecated APIs (Newtonsoft.Json and YamlDotNet) to supported API that is suggested by intellisense.
  • Set file-level warning suppression that need to use obsolete property for compatibility purpose.
  • Set [Obsolete] attribute to test code that tests obsolete code.

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (43bda19) 76.90% compared to head (2c1fa83) 76.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8937   +/-   ##
=======================================
  Coverage   76.90%   76.90%           
=======================================
  Files         605      605           
  Lines       25091    25088    -3     
=======================================
- Hits        19296    19294    -2     
+ Misses       5795     5794    -1     
Impacted Files Coverage Δ
...icrosoft.DocAsCode.Build.Engine/ManifestUtility.cs 76.74% <ø> (ø)
...ft.DocAsCode.Build.Engine/SingleDocumentBuilder.cs 82.87% <ø> (ø)
src/Microsoft.DocAsCode.Common/JsonUtility.cs 100.00% <100.00%> (ø)
...rializers/EmitGenericCollectionNodeDeserializer.cs 90.56% <100.00%> (ø)
...rializers/EmitGenericDictionaryNodeDeserializer.cs 64.00% <100.00%> (ø)
...eDeserializers/ExtensibleObjectNodeDeserializer.cs 77.77% <100.00%> (-0.80%) ⬇️
...rsalStrategies/FullObjectGraphTraversalStrategy.cs 93.10% <100.00%> (ø)
...ft.DocAsCode.YamlSerialization/YamlDeserializer.cs 86.92% <100.00%> (-0.20%) ⬇️
...soft.DocAsCode.YamlSerialization/YamlSerializer.cs 68.85% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you @filzrev !

@yufeih yufeih merged commit ed96e8d into dotnet:main Jul 5, 2023
7 checks passed
@yufeih yufeih added the engineering Makes the pull request to appear in the "Engineering" section of the next release note label Jul 5, 2023
@filzrev filzrev deleted the fix-obsolate-warningns2 branch July 5, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Makes the pull request to appear in the "Engineering" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants