Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support PDF cover page #9354

Merged
merged 2 commits into from
Oct 30, 2023
Merged

feat: Support PDF cover page #9354

merged 2 commits into from
Oct 30, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Oct 30, 2023

Supports PDF cover page through the pdfCoverPage config in toc.yml or as metadata in docfx.json.

The pdfCoverPage needs to point to build output location in this PR.

Removes pdfMargin and pdfPrintBackground metadata: they can be adjusted per page in CSS files.

#9343

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/Docfx.App/PdfBuilder.cs 8.91% <0.00%> (-0.18%) ⬇️

📢 Thoughts on this report? Let us know!.

@yufeih yufeih closed this Oct 30, 2023
@yufeih yufeih reopened this Oct 30, 2023
@yufeih yufeih merged commit a7b957c into main Oct 30, 2023
7 checks passed
@yufeih yufeih deleted the coverpage branch October 30, 2023 05:27
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant