Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: print page numbers using PdfPig #9381

Merged
merged 2 commits into from
Nov 6, 2023
Merged

perf: print page numbers using PdfPig #9381

merged 2 commits into from
Nov 6, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Nov 6, 2023

The current approach is inserting empty pages at the beginning of PDF files is too slow when there are lots of pages. This PR:

  • Removes the empty pages hack and prints the page number using PdfPig
  • Add snapshots test for PDF

#9373

@yufeih yufeih added the performance Makes the pull request appear in "Performance" section of the next release note label Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/Docfx.App/PdfBuilder.cs 63.75% <83.63%> (+0.81%) ⬆️

📢 Thoughts on this report? Let us know!.

@yufeih yufeih marked this pull request as ready for review November 6, 2023 06:23
@yufeih yufeih closed this Nov 6, 2023
@yufeih yufeih reopened this Nov 6, 2023
@yufeih yufeih merged commit 660c28e into main Nov 6, 2023
7 checks passed
@yufeih yufeih deleted the pdftest branch November 6, 2023 06:36
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
* perf: print page numbers using PdfPig

* test(snapshot): update snapshots for 63db8e2

---------

Co-authored-by: Yufei Huang <yufeih@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Makes the pull request appear in "Performance" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant