Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop phase from logger output #9387

Merged
merged 2 commits into from
Nov 7, 2023
Merged

chore: drop phase from logger output #9387

merged 2 commits into from
Nov 7, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Nov 7, 2023

phase isn't a stable contract to depend on for logger output, as we update the internals of the build engine, log messages may change the phase in which it occurs.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/Docfx.Common/Loggers/Logger.cs 61.62% <ø> (-0.17%) ⬇️
src/Docfx.Common/Loggers/ReportLogListener.cs 74.00% <ø> (-1.48%) ⬇️
test/Docfx.Tests.Common/TestLoggerListener.cs 76.92% <100.00%> (-7.99%) ⬇️
test/Docfx.Tests.Common/TestListenerScope.cs 93.75% <92.85%> (-6.25%) ⬇️

📢 Thoughts on this report? Let us know!

@yufeih yufeih marked this pull request as ready for review November 7, 2023 05:31
@yufeih yufeih merged commit fc06a3b into main Nov 7, 2023
6 checks passed
@yufeih yufeih deleted the nophase branch November 7, 2023 05:32
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
* chore: drop Phrase from output

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant