Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: drop keepFileLink #9417

Merged
merged 1 commit into from
Nov 11, 2023
Merged

BREAKING CHANGE: drop keepFileLink #9417

merged 1 commit into from
Nov 11, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Nov 11, 2023

Fixes #9181

@yufeih yufeih added the breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note label Nov 11, 2023
@yufeih yufeih changed the title Nokeepfilelink BREAKING CHANGE: drop keepFileLink Nov 11, 2023
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/Docfx.App/Config/BuildJsonConfig.cs 100.00% <ø> (ø)
src/Docfx.App/Helpers/DocumentBuilderWrapper.cs 74.25% <ø> (+0.87%) ⬆️
src/Docfx.Build/DocumentBuildParameters.cs 100.00% <ø> (ø)
src/Docfx.Build/DocumentBuilder.cs 83.63% <100.00%> (+3.97%) ⬆️
src/docfx/Models/BuildCommand.cs 12.00% <ø> (-1.73%) ⬇️
src/docfx/Models/BuildCommandOptions.cs 86.36% <ø> (-0.60%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

@yufeih yufeih marked this pull request as ready for review November 11, 2023 10:42
@yufeih yufeih merged commit 80d495b into main Nov 11, 2023
8 checks passed
@yufeih yufeih deleted the nokeepfilelink branch November 11, 2023 13:26
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Co-authored-by: Yufei Huang <yufeih@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Remove keepFileLink option from config
1 participant