Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for .NET8 #9424

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Nov 14, 2023

What's included in this PR

  • Update CI build to use .NET 8 SDK.
  • Update dotnet-sign tool version.
  • Update Microsoft.CodeAnalysis* packages to latest preview version (.NET 8 RTM version is not released yet)
  • Update following NuGet packages to .NET 8 version
    • Microsoft.Build
    • System.Collections.Immutable
    • System.Composition
  • Change TargetFrameworks to net6.0;net7.0;net8.0
    (it might be possible to drop .NET7 support. Because .NET 7 support lifecycle ends at May 14, 2024)

Backlog

  • It failed to run MetadataCommandTest at Docfx.Tests project when running on .NET 7 runtime. (with .NET 8 SDK)
  • Following packages needs to be updated to .NET 8 RTM version.
    • Microsoft.CodeAnalysis*
    • NuGet.Frameworks
  • Add C# 12 specific tests (e,g, C# 12 `ref readonly` parameters support #9339)

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a14aa4c) 71.37% compared to head (7a48627) 71.39%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9424      +/-   ##
==========================================
+ Coverage   71.37%   71.39%   +0.01%     
==========================================
  Files         561      561              
  Lines       23961    23961              
  Branches     4163     4163              
==========================================
+ Hits        17102    17106       +4     
+ Misses       5764     5762       -2     
+ Partials     1095     1093       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filzrev filzrev force-pushed the feat-add-support-for-dotnet-8 branch from 15cb114 to c9bb072 Compare November 14, 2023 23:53
@filzrev
Copy link
Contributor Author

filzrev commented Nov 15, 2023

It failed to run MetadataCommandTest at Docfx.Tests project when running on .NET 7 runtime. (with .NET 8 SDK)

This problems is occurred on my local environment (Windows) only.
And it's not occurred on CI environment. (I've tested by temporary enable .NET 7 CI tests for Windows/macOS).

It can be resolved by this commit (c9bb072)
It seems Directory.Build.props settings are applied for tests assets project.
And both TargetFramework and TargetFrameworks are specified.
So I've changed TargetFramework setting to TargetFrameworks to use project-side settings.

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you @filzrev !

@filzrev filzrev marked this pull request as ready for review November 15, 2023 10:40
@filzrev
Copy link
Contributor Author

filzrev commented Nov 15, 2023

I've removed Draft from PR.

Remaining issues
Following issues should be resolved by another PR.

  • When .NET 8 RTM version released. Update following packages by dependabot.
    • Microsoft.CodeAnalysis*
    • NuGet.Frameworks
  • Add C# 12 features tests. (If required)

@yufeih yufeih merged commit be96e63 into dotnet:main Nov 15, 2023
7 of 8 checks passed
@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Nov 20, 2023
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
* feat: Add support for .NET8

* chore: fix target frameworks for test assets project

* chore: update Microsoft.Build NuGet package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants