Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add solution filter file (.slnf) supports #9513

Merged
merged 1 commit into from
Dec 13, 2023
Merged

feat: Add solution filter file (.slnf) supports #9513

merged 1 commit into from
Dec 13, 2023

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Dec 7, 2023 •
edited
Loading

What's included in this PR

  • Add Solution Filter (.slnf) file supports.
  • Fix log message for unsupported file.
  • Update related documents.

Test
I've manually confirmed,.
It's works when .slnf file is specifying as input for docfx metadata command.

@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0bebd86) 71.34% compared to head (f2335ba) 71.34%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/Docfx.Dotnet/DotnetApiCatalog.Compile.cs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9513   +/-   ##
=======================================
  Coverage   71.34%   71.34%           
=======================================
  Files         558      558           
  Lines       24048    24048           
  Branches     4182     4182           
=======================================
  Hits        17156    17156           
  Misses       5793     5793           
  Partials     1099     1099

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yufeih
yufeih approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @filzrev !

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Dec 13, 2023
@yufeih yufeih merged commit 415d4fc into dotnet:main Dec 13, 2023
8 checks passed
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
@filzrev @p-kostov
feat: Add solution filter file (.slnf) supports (dotnet#9513)
5f7275f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufeih yufeih yufeih approved these changes

Assignees
No one assigned
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filzrev @yufeih