Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warn on PDF timeout #9586

Merged
merged 1 commit into from
Jan 6, 2024
Merged

fix: warn on PDF timeout #9586

merged 1 commit into from
Jan 6, 2024

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Jan 6, 2024

Gracefully warn and handle PDF wait timeout.

Fixes #9577

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Jan 6, 2024
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (305cabf) 74.36% compared to head (df1544e) 74.35%.

Files Patch % Lines
src/Docfx.App/PdfBuilder.cs 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9586      +/-   ##
==========================================
- Coverage   74.36%   74.35%   -0.01%     
==========================================
  Files         536      536              
  Lines       23162    23166       +4     
  Branches     4049     4049              
==========================================
+ Hits        17225    17226       +1     
- Misses       4836     4839       +3     
  Partials     1101     1101              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih merged commit 28b1ab1 into main Jan 6, 2024
8 checks passed
@yufeih yufeih deleted the pdf-timeout branch January 6, 2024 03:12
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] PDF Rendering stops after default timeout has been exceeded
1 participant