Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update nuget dependencies #9587

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Jan 6, 2024

This PR manually update following package dependencies.

  • Microsoft.NET.Test.Sdk
  • xunit
  • xunit.runner.visualstudio

Note: I don't know why dependabot don't create PR automatically for xunit packages.
(It seems worked before November 20)


To resolve following warning.
I've modified ModelAttributeHandlerTest.cs.

Warning xUnit2027 Comparing an instance of List with an instance of HashSet has undefined results, because the order of items in the set is not predictable. Create a stable order for the set (i.e., by using OrderBy from Linq).

@filzrev filzrev force-pushed the chore-update-nuget-dependencies branch from 26e1625 to 39b80ff Compare January 6, 2024 23:10
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (44ca36f) 74.35% compared to head (39b80ff) 74.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9587      +/-   ##
==========================================
- Coverage   74.35%   74.34%   -0.02%     
==========================================
  Files         536      536              
  Lines       23162    23162              
  Branches     4049     4049              
==========================================
- Hits        17222    17219       -3     
- Misses       4839     4841       +2     
- Partials     1101     1102       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @filzrev !

@yufeih yufeih merged commit 8cf1652 into dotnet:main Jan 8, 2024
8 checks passed
@yufeih yufeih added the engineering Makes the pull request to appear in the "Engineering" section of the next release note label Jan 8, 2024
@filzrev filzrev deleted the chore-update-nuget-dependencies branch April 1, 2024 05:03
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Makes the pull request to appear in the "Engineering" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants