Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove PDF missing TOC warning #9610

Merged
merged 1 commit into from
Jan 13, 2024
Merged

fix: remove PDF missing TOC warning #9610

merged 1 commit into from
Jan 13, 2024

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Jan 13, 2024

Fixes #9608

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Jan 13, 2024
Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6476473) 74.35% compared to head (8767fc2) 74.34%.

Files Patch % Lines
src/Docfx.App/PdfBuilder.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9610      +/-   ##
==========================================
- Coverage   74.35%   74.34%   -0.01%     
==========================================
  Files         536      536              
  Lines       23162    23161       -1     
  Branches     4049     4049              
==========================================
- Hits        17222    17220       -2     
- Misses       4839     4840       +1     
  Partials     1101     1101              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih merged commit 6f8e2ce into main Jan 13, 2024
8 checks passed
@yufeih yufeih deleted the no-pdf-warn branch January 13, 2024 02:45
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Breaking change in 2.75.0 - ---warningsAsErrors fails if no PDF TOC is provided in project
1 participant