Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for networking Runtime Configuration Options #21197

Merged
merged 5 commits into from
Oct 30, 2020
Merged

Update docs for networking Runtime Configuration Options #21197

merged 5 commits into from
Oct 30, 2020

Conversation

antonfirsov
Copy link
Member

Fixes 2 issues:

  1. HTTP/2 is enabled by default since 3.1, the docs did not reflect this change
  2. Document the AllowLatin1Headers switch introduced in SocketsHttpHandler: Add a switch to allow non-ascii headers corefx#42978

@antonfirsov
Update runtime configuration options docs for http
848c578 
- HTTP/2 is enabled by default since 3.1
- Document the "AllowLatin1Headers" switch
@dotnet-bot dotnet-bot added this to the October 2020 milestone Oct 23, 2020
@antonfirsov antonfirsov requested a review from a team October 23, 2020 14:53
@antonfirsov antonfirsov mentioned this pull request Oct 23, 2020
Merged
gewarren
gewarren approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this. I left a few suggestions for consideration.

docs/core/run-time-config/networking.md Outdated Show resolved Hide resolved
docs/core/run-time-config/networking.md Outdated Show resolved Hide resolved
docs/core/run-time-config/networking.md Outdated Show resolved Hide resolved
antonfirsov and others added 3 commits October 23, 2020 18:59
@antonfirsov @gewarren
commit suggestion
f5ecc65 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@antonfirsov @gewarren
commit suggestion
c5d6166 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@antonfirsov @gewarren
commit suggestion
135a83b 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
ManickaP
ManickaP approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@antonfirsov antonfirsov merged commit 1846c25 into master Oct 30, 2020
@antonfirsov antonfirsov deleted the antonfirsov-rcoptions-http branch October 30, 2020 13:12
antonfirsov added a commit to dotnet/dotnet-api-docs that referenced this pull request Oct 30, 2020
@antonfirsov
HttpClient: remove redundant and outdated runtime config switch infor…
70dc619 
…mation (#5028)

Removes redundant and outdated information about runtime configuration options for HttpClient, referencing the options docs page instead.

Related PR updating the options docs: dotnet/docs#21197
This was referenced Jun 6, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManickaP ManickaP ManickaP approved these changes

@gewarren gewarren gewarren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
October 2020
Development

Successfully merging this pull request may close these issues.
5 participants
@antonfirsov @ManickaP @gewarren @BillWagner @dotnet-bot