Added documentation for new rule CA1847 - Use string.Contains(char) w… #23377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gewarren probably should also get the "Hold for related PR" tag |
3 tasks
gewarren
added
the
🚧 Hold for related PR
|
Changed to draft to prevent any accidental merge 😁 |
MeikTranel
force-pushed
the
NewRule-StringContainsChar
branch
from
ddf4daa
to
4cf602d
Compare
MeikTranel
changed the title
MeikTranel
force-pushed
the
NewRule-StringContainsChar
branch
from
4cf602d
to
18cac92
Compare
MeikTranel
changed the title
|
Has the rule ID changed again? It looks like CA1846 was used for prefer AsSpan. |
|
Yes, I've just picked up the original PR for requested changes again. I'll update this PR when the roslyn-analyzer PR gets merged. |
|
Upstream PR has been merged now. Will be pushing the final changes to the PR later today. |
MeikTranel
force-pushed
the
NewRule-StringContainsChar
branch
from
18cac92
to
8760b8f
Compare
|
@gewarren can we get this PR forward? The roslyn-analyzer PR has been merged for a while now ;) |
22 tasks
MeikTranel
changed the title
Youssef1313
reviewed
Jun 14, 2021
Youssef1313
reviewed
Jun 14, 2021
MeikTranel
force-pushed
the
NewRule-StringContainsChar
branch
from
8760b8f
to
8d82ab9
Compare
adegeo
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds required documentation for rule CA1847
Required documentation for dotnet/runtime#47180 (PR: https://github.com/dotnet/roslyn-analyzers/pull/4908/files)
Related