Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensions breaking changes #33714

Merged
merged 7 commits into from
Mar 7, 2023
Merged

Extensions breaking changes #33714

merged 7 commits into from
Mar 7, 2023

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jan 25, 2023 •
edited
Loading

@dotnet-bot dotnet-bot added this to the January 2023 milestone Jan 25, 2023
@ghost ghost added the 🏁 Release: .NET 8 Work items for the .NET 8 release label Jan 25, 2023
@gewarren gewarren requested review from maryamariyan and a team January 26, 2023 19:55
@gewarren gewarren changed the title CreateInstance breaking change Extensions breaking changes Jan 28, 2023
@BillWagner BillWagner modified the milestones: January 2023, February 2023 Feb 5, 2023
IEvangelist
IEvangelist approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but have a few comments and suggestions.

docs/core/compatibility/extensions/8.0/activatorutilities-createinstance-behavior.md Show resolved Hide resolved
docs/core/compatibility/extensions/8.0/configurationbinder-exceptions.md Outdated Show resolved Hide resolved
@gewarren @IEvangelist
Update docs/core/compatibility/extensions/8.0/configurationbinder-exc…
84a59af 
…eptions.md

Co-authored-by: David Pine <david.pine@microsoft.com>
@gewarren gewarren enabled auto-merge (squash) March 7, 2023 18:42
@gewarren gewarren merged commit e2fa772 into dotnet:main Mar 7, 2023
@gewarren gewarren deleted the createinstance branch March 7, 2023 18:52
@miguelnunes94 miguelnunes94 mentioned this pull request Jan 22, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

@maryamariyan maryamariyan Awaiting requested review from maryamariyan

@steveharter steveharter Awaiting requested review from steveharter

Assignees
No one assigned
Labels
🏁 Release: .NET 8 Work items for the .NET 8 release dotnet-fundamentals/svc
Projects
None yet
Milestone
February 2023
4 participants
@gewarren @IEvangelist @BillWagner @dotnet-bot