Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect implementation detail #42699

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Remove incorrect implementation detail #42699

merged 1 commit into from
Sep 25, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Sep 24, 2024 •
edited by github-actions bot
Loading

@gewarren gewarren requested a review from a team as a code owner September 24, 2024 20:58
@gewarren gewarren enabled auto-merge (squash) September 24, 2024 20:58
@dotnetrepoman dotnetrepoman bot added this to the September 2024 milestone Sep 24, 2024
BillWagner
BillWagner approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit e780d61 into dotnet:main Sep 25, 2024
10 checks passed
@gewarren gewarren deleted the stringbuilder branch September 25, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
September 2024
Development

Successfully merging this pull request may close these issues.

Confusion about StringBuilder memory allocation
2 participants
@gewarren @BillWagner