Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ObjectDisposedException to Socket.Select member #4720

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Add ObjectDisposedException to Socket.Select member #4720

merged 1 commit into from
Aug 31, 2020

Conversation

aik-jahoda
Copy link
Contributor

Summary

Add missing exception in .net 5:
When Socket is disposed then Socket.Select throws ObjectDisposedException.

Fixes dotnet/runtime#34886

@opbld31
Copy link

opbld31 commented Aug 24, 2020

Docs Build status updates of commit 349f1a2:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
xml/System.Reflection.Emit/EnumBuilder.xml ❌Error Details
xml/System.Reflection.Emit/GenericTypeParameterBuilder.xml ❌Error Details
xml/System.Reflection.Emit/TypeBuilder.xml ❌Error Details
xml/System.Security.Cryptography/SHA384Managed.xml ❌Error Details
xml/System.Security.Cryptography/SHA1Managed.xml ❌Error Details
xml/System.Security.Cryptography/SHA512Managed.xml ❌Error Details
xml/System.Security.Cryptography/SHA256Managed.xml ❌Error Details
xml/System.Security.Cryptography/RNGCryptoServiceProvider.xml ❌Error Details
xml/System.Transactions.Configuration/MachineSettingsSection.xml ❌Error Details
xml/System.Transactions.Configuration/DefaultSettingsSection.xml ❌Error Details

xml/System.Reflection.Emit/EnumBuilder.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

xml/System.Reflection.Emit/GenericTypeParameterBuilder.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

xml/System.Reflection.Emit/TypeBuilder.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

xml/System.Security.Cryptography/SHA384Managed.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

xml/System.Security.Cryptography/SHA1Managed.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

xml/System.Security.Cryptography/SHA512Managed.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

xml/System.Security.Cryptography/SHA256Managed.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

xml/System.Security.Cryptography/RNGCryptoServiceProvider.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

xml/System.Transactions.Configuration/MachineSettingsSection.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

xml/System.Transactions.Configuration/DefaultSettingsSection.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@aik-jahoda
Copy link
Contributor Author

@gewarren, do you know why there are errors in above comment? It is related to files which are not in scope of this PR. Also the docs is not published to review.docs.microsoft.com.

@BillWagner
Copy link
Member

closing and reopening to trigger a new build. The issue noted above is fixed.

@BillWagner BillWagner closed this Aug 25, 2020
@BillWagner BillWagner reopened this Aug 25, 2020
@opbld34
Copy link

opbld34 commented Aug 25, 2020

Docs Build status updates of commit 349f1a2:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Sockets/Socket.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@aik-jahoda aik-jahoda requested a review from a team August 25, 2020 15:18
antonfirsov
antonfirsov approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gewarren gewarren merged commit 8e5e843 into dotnet:master Aug 31, 2020
@karelz karelz mentioned this pull request Sep 1, 2020
Closed
@aik-jahoda aik-jahoda deleted the jajahoda/selectObjectDisposedException branch September 2, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonfirsov antonfirsov antonfirsov approved these changes

@gewarren gewarren gewarren approved these changes

Assignees
No one assigned
Labels
area-System.Net.Sockets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Socket.Select throws ObjectDisposedException when one of the sockets is disposed
7 participants
@aik-jahoda @opbld31 @BillWagner @opbld34 @antonfirsov @gewarren @eiriktsarpalis