Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port docs from WinForms #8394

Merged
merged 4 commits into from
Sep 16, 2022
Merged

Conversation

carlossanlop
Copy link
Member

@RussKie @JeremyKuhne This is all I could port from the winforms release/7.0-rc1 branch.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

xml/System.Windows.Forms/BindableComponent.xml Outdated Show resolved Hide resolved
xml/System.Windows.Forms/ButtonBase.xml Outdated Show resolved Hide resolved
xml/System.Windows.Forms/ButtonBase.xml Outdated Show resolved Hide resolved
xml/System.Windows.Forms/ButtonBase.xml Outdated Show resolved Hide resolved
xml/System.Windows.Forms/ContainerControl.xml Outdated Show resolved Hide resolved
xml/System.Windows.Forms/ToolStripItem.xml Outdated Show resolved Hide resolved
xml/System.Windows.Forms/ToolStripItem.xml Outdated Show resolved Hide resolved
xml/System.Windows.Forms/BindableComponent.xml Outdated Show resolved Hide resolved
@opbld31

This comment was marked as outdated.

@opbld34

This comment was marked as outdated.

@RussKie
Copy link
Member

RussKie commented Sep 15, 2022

Tagging @KlausLoeffelmann since he added the new API to Windows Forms 😉

@RussKie
Copy link
Member

RussKie commented Sep 15, 2022

Tagging @dreddy-work as he added new API as well

@KlausLoeffelmann
Copy link
Member

Looks good to me!

Copy link
Member

@dreddy-work dreddy-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Winforms.

@RussKie
Copy link
Member

RussKie commented Sep 16, 2022

Thank you @carlossanlop and @gewarren for doing this

@carlossanlop
Copy link
Member Author

@cston @dreddy-work @RussKie I'll manually apply the requested changes. But if you have additional feedback, please help @gewarren and I by providing GitHub suggestions with the preferred texts. It's much faster to bulk apply them in a single commit.

carlossanlop and others added 2 commits September 16, 2022 10:28
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld32

This comment was marked as outdated.

@opbld32

This comment was marked as outdated.

@carlossanlop
Copy link
Member Author

System.Windows.Forms.Application.ThreadContext.PreTranslateMessage(Interop.User32.MSG@) doesn't exist, or is internal. Need to remove it.

@opbld32
Copy link

opbld32 commented Sep 16, 2022

Docs Build status updates of commit 5866fd7:

💡 Validation status: suggestions

File Status Preview URL Details
xml/System.ComponentModel.Design/ObjectSelectorEditor.xml 💡Suggestion View Details
xml/System.Windows.Forms/TaskDialogButtonCollection.xml 💡Suggestion View Details
xml/System.Windows.Forms/TaskDialogRadioButtonCollection.xml 💡Suggestion View Details
xml/System.ComponentModel.Design/BinaryEditor.xml ✅Succeeded View
xml/System.ComponentModel.Design/CollectionEditor.xml ✅Succeeded View
xml/System.ComponentModel.Design/DateTimeEditor.xml ✅Succeeded View
xml/System.ComponentModel.Design/MultilineStringEditor.xml ✅Succeeded View
xml/System.Drawing.Design/ColorEditor.xml ✅Succeeded View
xml/System.Drawing.Design/ContentAlignmentEditor.xml ✅Succeeded View
xml/System.Drawing.Design/CursorEditor.xml ✅Succeeded View
xml/System.Drawing.Design/FontEditor.xml ✅Succeeded View
xml/System.Drawing.Design/FontNameEditor.xml ✅Succeeded View
xml/System.Drawing.Design/IconEditor.xml ✅Succeeded View
xml/System.Drawing.Design/ImageEditor.xml ✅Succeeded View
xml/System.Windows.Forms.Design/AnchorEditor.xml ✅Succeeded View
xml/System.Windows.Forms.Design/BorderSidesEditor.xml ✅Succeeded View
xml/System.Windows.Forms.Design/DockEditor.xml ✅Succeeded View
xml/System.Windows.Forms.Design/EventsTab.xml ✅Succeeded View
xml/System.Windows.Forms.Design/FileNameEditor.xml ✅Succeeded View
xml/System.Windows.Forms.Design/FolderNameEditor.xml ✅Succeeded View
xml/System.Windows.Forms.Design/ShortcutKeysEditor.xml ✅Succeeded View
xml/System.Windows.Forms/BindableComponent.xml ✅Succeeded View
xml/System.Windows.Forms/ButtonBase.xml ✅Succeeded View
xml/System.Windows.Forms/ContainerControl.xml ✅Succeeded View
xml/System.Windows.Forms/Control.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.

xml/System.ComponentModel.Design/ObjectSelectorEditor.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:SetValue(System.Object) for uid: System.ComponentModel.Design.ObjectSelectorEditor.SetValue(System.Object).

xml/System.Windows.Forms/TaskDialogButtonCollection.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:InsertItem(System.Int32,System.Windows.Forms.TaskDialogButton) for uid: System.Windows.Forms.TaskDialogButtonCollection.InsertItem(System.Int32,System.Windows.Forms.TaskDialogButton).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs] Inheridoc tag exists but no inheritdoc found for uid:System.Windows.Forms.TaskDialogButtonCollection.InsertItem(System.Int32,System.Windows.Forms.TaskDialogButton).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:SetItem(System.Int32,System.Windows.Forms.TaskDialogButton) for uid: System.Windows.Forms.TaskDialogButtonCollection.SetItem(System.Int32,System.Windows.Forms.TaskDialogButton).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs] Inheridoc tag exists but no inheritdoc found for uid:System.Windows.Forms.TaskDialogButtonCollection.SetItem(System.Int32,System.Windows.Forms.TaskDialogButton).

xml/System.Windows.Forms/TaskDialogRadioButtonCollection.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:InsertItem(System.Int32,System.Windows.Forms.TaskDialogRadioButton) for uid: System.Windows.Forms.TaskDialogRadioButtonCollection.InsertItem(System.Int32,System.Windows.Forms.TaskDialogRadioButton).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs] Inheridoc tag exists but no inheritdoc found for uid:System.Windows.Forms.TaskDialogRadioButtonCollection.InsertItem(System.Int32,System.Windows.Forms.TaskDialogRadioButton).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:SetItem(System.Int32,System.Windows.Forms.TaskDialogRadioButton) for uid: System.Windows.Forms.TaskDialogRadioButtonCollection.SetItem(System.Int32,System.Windows.Forms.TaskDialogRadioButton).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs] Inheridoc tag exists but no inheritdoc found for uid:System.Windows.Forms.TaskDialogRadioButtonCollection.SetItem(System.Int32,System.Windows.Forms.TaskDialogRadioButton).

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@carlossanlop
Copy link
Member Author

Warning removed. Merging now. :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants