Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cmake 3.6.2 and clang/llvm7 #354

Merged
merged 4 commits into from
Aug 11, 2020
Merged

Add cmake 3.6.2 and clang/llvm7 #354

merged 4 commits into from
Aug 11, 2020

Conversation

jashook
Copy link
Contributor

@jashook jashook commented Aug 4, 2020

No description provided.

@jashook
Copy link
Contributor Author

jashook commented Aug 4, 2020

@omajid @jkoritzinsky ptal

@omajid
Copy link
Member

omajid commented Aug 5, 2020

I don't think this will work, unfortunately. The scl ... bash command starts a new bash session in which cmake is available on the $PATH. That session ends after the run command. I don't think the runtime build will find this cmake executible as it is, without further changes.

@jashook
Copy link
Contributor Author

jashook commented Aug 5, 2020

@omajid thank you for the review I have changed to use ENTRYPOINT in place of run. :)

@jashook
Copy link
Contributor Author

jashook commented Aug 5, 2020

ptal @janvorli

@jashook
Copy link
Contributor Author

jashook commented Aug 6, 2020

ping @omajid @janvorli @jkoritzinsky

janvorli
janvorli approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jashook
Copy link
Contributor Author

jashook commented Aug 11, 2020

@mthalman ptal

@mthalman mthalman merged commit 560e5e7 into dotnet:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvorli janvorli janvorli approved these changes

@mthalman mthalman mthalman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jashook @omajid @janvorli @mthalman