Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable building of ARM32 Helix images #363

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Disable building of ARM32 Helix images #363

merged 1 commit into from
Aug 26, 2020

Conversation

mthalman
Copy link
Member

Disabling these images to workaround #359 and unblock builds.

MattGal
MattGal approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, I'll synch up with you later about how we'll handle this going forward.

MichaelSimons
MichaelSimons approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. It makes me wonder if we should add a disable metadata flag to better accommodate scenarios in which we want to temporarily not build an image. Thoughts?

@mthalman
Copy link
Member Author

The changes look good. It makes me wonder if we should add a disable metadata flag to better accommodate scenarios in which we want to temporarily not build an image. Thoughts?

Same thought occurred to me. 👍

@mthalman mthalman merged commit ca7b55d into dotnet:master Aug 26, 2020
@mthalman mthalman deleted the disable-helix-arm32 branch August 26, 2020 19:17
@MichaelSimons MichaelSimons mentioned this pull request Aug 26, 2020
Open
MattGal added a commit that referenced this pull request Sep 2, 2020
@MattGal
Revert "Disable building of ARM32 Helix images (#363)"
8181660 
This reverts commit ca7b55d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattGal MattGal MattGal approved these changes

@MichaelSimons MichaelSimons MichaelSimons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mthalman @MattGal @MichaelSimons