Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add llvm-symbolizer to all more helix images #966

Merged
merged 14 commits into from
Feb 28, 2024

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Jan 24, 2024

No description provided.

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to/can we copy the live-built llvm-symbolizer from our cross-build image here so we can ensure our toolchain is consistent?

If that's not possible, I understand. LGTM in that case

@hoyosjs hoyosjs changed the title Add llvm-symbolizer to all alpine helix images Add llvm-symbolizer to all more helix images Jan 25, 2024
@hoyosjs
Copy link
Member Author

hoyosjs commented Jan 31, 2024

@mthalman are these build issues known? They seem to be in npm and Python, but rebuilds didn't help

@mthalman
Copy link
Member

@mthalman are these build issues known? They seem to be in npm and Python, but rebuilds didn't help

@lbussell

@lbussell
Copy link
Contributor

@mthalman are these build issues known? They seem to be in npm and Python, but rebuilds didn't help

it's #903. https://github.com/dotnet/dotnet-buildtools-prereqs-docker/pull/929/files solved this for debian, but there's no binary distribution of python3-cryptography for Alpine. I think we would need to follow the troubleshooting steps in cryptography's documentation under "Rust".

@lbussell
Copy link
Contributor

Actually I lied and found the package. We should try installing py3-cryptography.

@hoyosjs
Copy link
Member Author

hoyosjs commented Feb 5, 2024

@lbussell adding that package requires gcc, but that might make the container pretty big. Not sure if purging gcc after is an option, or if we should just let it be

@JulieLeeMSFT
Copy link
Member

Hi @lbussell, we need your help to fix this issue. We are trying to roll out the feature by Feb, so we need this done ASAP.

@lbussell
Copy link
Contributor

lbussell commented Feb 7, 2024

@JulieLeeMSFT These Dockerfiles are the responsibility of repo owners to maintain (e.g. runtime devs) since they are the devs who need them. I did my best effort to try and fix the problem in my spare time.

I see two blocking issues in this PR:

  1. An issue with npm in an Ubuntu Dockerfile. I haven't taken a look at this. It looks unrelated to @hoyosjs's change unfortunately.
  2. An issue with Helix dependencies in an Alpine arm32 Dockerfile. I tried to fix this based on our own experience with similar issues in the past. /cc @epananth @davfost for help with Helix dependency issues and @wfurt who had helped fix this issue for Debian.

If it's an option, we could disable the images that fail to build. But since @hoyosjs touched the files that are failing to build I'm guessing they're important.

@epananth
Copy link
Member

epananth commented Feb 8, 2024

Probably @dougbu has some insights on this?

@dougbu
Copy link
Member

dougbu commented Feb 8, 2024

I generally agree w/ @lbussell. we haven't found viable workarounds for the cffi on ARM32 issue due to resource constraints. installing C++ and Rust, then removing them might be the best option. right now, it seems we haven't found the perfect set of commands. continuing to experiment here seems like the best option

@lbussell
Copy link
Contributor

Submitted dotnet/runtime#98531 so that we can move towards deleting the offending alpine 3.16 image.

@hoyosjs
Copy link
Member Author

hoyosjs commented Feb 28, 2024

@radical @radekdoulik I changed the versions to pin things to the last working versions for 18.04. That being said, I can't see a place that uses the 18.04 webassembly image. Can it be removed? the node version and dependencies are no longer maintained.

@hoyosjs hoyosjs merged commit 0ee595b into dotnet:main Feb 28, 2024
101 checks passed
@hoyosjs hoyosjs deleted the juhoyosa/add-llvm-to-helix-containers branch February 28, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants