Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set console formatter to JSON in ASP.NET Core images #2748

Merged
merged 3 commits into from
Apr 19, 2021

Conversation

mthalman
Copy link
Member

Fixes #2725

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

# Install ASP.NET Core
ENV ASPNET_VERSION={{VARIABLES["aspnet|6.0|build-version"]}}
ENV \
ASPNET_VERSION={{VARIABLES["aspnet|6.0|build-version"]}} \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Rich's recent PR to refactor the first run, he added a comment for the SDK_VERSION. Thoughts on doing a similar thing for the ASPNET_VERSION?

Referenced change - 34775be

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, need to regen

@mthalman mthalman merged commit 9333016 into dotnet:nightly Apr 19, 2021
@mthalman mthalman deleted the issue2725 branch April 19, 2021 17:08
@mthalman mthalman mentioned this pull request May 25, 2021
22 tasks
mthalman added a commit to mthalman/dotnet-docker that referenced this pull request May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants