Use higher number UID #4476
Merged
Use higher number UID #4476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
mthalman
reviewed
Mar 6, 2023
eng/dockerfile-templates/runtime-deps/Dockerfile.distroless-mariner
Outdated
Show resolved
Hide resolved
|
Since we are explicitly making this change to ensure a user ID >10,000, consider adding a unit test to validate this. There are two valuable outcomes of this. One, we ensure our ID is > 10,000. Two, we ensure a consistent UID across all of our images (at least the subset we are able to make this change in). |
MichaelSimons
approved these changes
Mar 8, 2023
mthalman
approved these changes
Mar 8, 2023
MichaelSimons
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4451 and specifically #4451 (comment)