Schema Tag Tests #5878
Schema Tag Tests #5878
Conversation
| if (!repo.Name.Contains("monitor")) | ||
| { | ||
| // Monitor repos don't have these tags | ||
| testObjects.Add(GetTagTestInput(testType, repo, 1, false, true, IsApplianceVersionUsingOldSchema)); // <Major>-<architecture> | ||
| } |
There was a problem hiding this comment.
@lbussell - Is this intentional? Why isn't this consistent?
There was a problem hiding this comment.
Yes - IIRC .NET Monitor wants to explicitly make moving between minor versions intentional.
/cc @jander-msft
There was a problem hiding this comment.
Aspire on the other hand has only one major.minor version supported at a time.
There was a problem hiding this comment.
This is specifically related to the <major>-<arch> pattern. Monitor already has a 9 tag but no 9-amd64 tag. But Aspire has both 8 and 8-amd64.
There was a problem hiding this comment.
It looks like dotnet/monitor and dotnet/monitor-base is missing the following tag patterns:
<major>.<minor>-<arch>(for everything before 9)<major>-<arch>(for all versions)
I think it makes sense to have these added, at least from a consistency standpoint.
There was a problem hiding this comment.
On the other hand, the introduction of the <major>.<minor>-<arch> and <major>-<arch> tag schemes was largely only done for the Aspire dashboard. Take the dotnet/runtime repo as an example; while it doesn't contain major-only tags, there are no <major>.<minor>-<arch> tags. However, there are <major>.<minor>-<distro>-<arch> tags. The .NET Monitor images are, by-in-large, consistent with these tag schemes in the base .NET images whereas the Aspire images have introduced a new pattern.
We'll have to investigate the reasoning as to why the <major>.<minor>-<arch> were never added to the base .NET images and see if the same reasoning should apply to the appliance-style images. I'll open an issue to document the inconsistency and allow discussion separate from this PR on what should be done to rectify the inconsistency.
There was a problem hiding this comment.
I'll open an issue to document the inconsistency and allow discussion separate from this PR on what should be done to rectify the inconsistency.
This is a great path forward. Thank you for filing the issue and starting this discussion.
I spoke with the team offline, and the decision is to go ahead with merging the changes in this PR. These tests can then be adjusted later given the future discussion on the issue.
I'll leave this comment thread open as well.
Closes #5838
Introduces schema tag tests (the second half of the static tag tests). I have introduced three new types of tests in this PR:
<major.minor.patch>-<os>-<arch>,<major.minor.patch>-<os>, etc)These tests use a dictionary of dockerfiles to tags, so this PR also introduces that logic in
ManifestHelper.cs.