Updated to return constant hash codes.

dotnet · Dec 17, 2021 · 4f7c38c · 4f7c38c
1 parent e167674
commit 4f7c38c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 21 deletions.
diff --git a/src/EFCore.Relational/Query/SqlExpressions/SelectExpression.Helper.cs b/src/EFCore.Relational/Query/SqlExpressions/SelectExpression.Helper.cs
@@ -340,7 +340,6 @@ public AliasUniquifier(HashSet<string> usedAliases)
 
     private sealed class TableReferenceExpression : Expression
     {
-        private int? _hashCode;
         private SelectExpression _selectExpression;
 
         public TableReferenceExpression(SelectExpression selectExpression, string alias)
@@ -393,15 +392,7 @@ private bool Equals(TableReferenceExpression tableReferenceExpression)
 
         /// <inheritdoc />
         public override int GetHashCode()
-        {
-            // ReSharper disable NonReadonlyMemberInGetHashCode
-            // Ensure hashcode does not change after it has been created for this object.
-            Check.DebugAssert(
-                _hashCode == null || _hashCode == HashCode.Combine(Alias),
-                "Hashed value has mutated.");
-
-            return _hashCode ??= HashCode.Combine(Alias);
-        }
+            => 0;
     }
 
     private sealed class ConcreteColumnExpression : ColumnExpression

diff --git a/src/EFCore.Relational/Query/SqlExpressions/TableExpressionBase.cs b/src/EFCore.Relational/Query/SqlExpressions/TableExpressionBase.cs
@@ -14,8 +14,6 @@ namespace Microsoft.EntityFrameworkCore.Query.SqlExpressions;
 /// </summary>
 public abstract class TableExpressionBase : Expression, IPrintableExpression
 {
-    private int? _hashCode;
-
     /// <summary>
     ///     Creates a new instance of the <see cref="TableExpressionBase" /> class.
     /// </summary>
@@ -64,13 +62,5 @@ private bool Equals(TableExpressionBase tableExpressionBase)
 
     /// <inheritdoc />
     public override int GetHashCode()
-    {
-        // ReSharper disable NonReadonlyMemberInGetHashCode
-        // Ensure hashcode does not change after it has been created for this object.
-        Check.DebugAssert(
-            _hashCode == null || _hashCode == HashCode.Combine(Alias),
-            "Hashed value has mutated.");
-
-        return _hashCode ??= HashCode.Combine(Alias);
-    }
+        => 0;
 }