Replace NotImplementedException with NotSupportedException (#23502)

Fixes #20961

> You might choose to throw a NotImplementedException exception in properties or methods in your own types when the that member is still in development and will only later be implemented in production code. In other words, a NotImplementedException exception should be synonymous with "still in development."

I left one NotImplementedException in Migration.cs, because it really is there for when the application hasn't implemented Down yet, but tries to do a Down.

src/EFCore.Cosmos/Properties/CosmosStrings.resx

@@ -117,6 +117,9 @@
   <resheader name="writer">
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
+  <data name="CanConnectNotSupported" xml:space="preserve">
+    <value>The Cosmos database does not support 'CanConnect' or 'CanConnectAsync'.</value>
+  </data>
   <data name="ConnectionStringConflictingConfiguration" xml:space="preserve">
     <value>Both the connection string and account key or account endpoint were specified. Specify only one set of connection details.</value>
   </data>
@@ -215,6 +218,9 @@
   <data name="ReverseAfterSkipTakeNotSupported" xml:space="preserve">
     <value>Reversing the ordering is not supported when limit or offset are already applied.</value>
   </data>
+  <data name="TransactionsNotSupported" xml:space="preserve">
+    <value>The Cosmos database provider does not support transactions.</value>
+  </data>
   <data name="UnableToBindMemberToEntityProjection" xml:space="preserve">
     <value>Unable to bind '{memberType}' '{member}' to an entity projection of '{entityType}'.</value>
   </data>

src/EFCore.Cosmos/Query/Internal/CosmosShapedQueryCompilingExpressionVisitor.QueryingEnumerable.cs

@@ -179,7 +179,7 @@ public void Dispose()
                 }
 
                 public void Reset()
-                    => throw new NotImplementedException();
+                    => throw new NotSupportedException(CoreStrings.EnumerableResetNotSupported);
             }
 
             private sealed class AsyncEnumerator : IAsyncEnumerator<T>

src/EFCore.Cosmos/Query/Internal/CosmosShapedQueryCompilingExpressionVisitor.ReadItemQueryingEnumerable.cs

@@ -290,7 +290,7 @@ public ValueTask DisposeAsync()
                 }
 
                 public void Reset()
-                    => throw new NotImplementedException();
+                    => throw new NotSupportedException(CoreStrings.EnumerableResetNotSupported);
 
                 private bool ShapeResult()
                 {

src/EFCore.Cosmos/Query/Internal/CosmosShapedQueryCompilingExpressionVisitor.cs

@@ -4,6 +4,7 @@
 using System;
 using System.Linq.Expressions;
 using JetBrains.Annotations;
+using Microsoft.EntityFrameworkCore.Diagnostics;
 using Microsoft.EntityFrameworkCore.Query;
 using Microsoft.EntityFrameworkCore.Utilities;
 using Newtonsoft.Json.Linq;
@@ -110,7 +111,7 @@ protected override Expression VisitShapedQuery(ShapedQueryExpression shapedQuery
                             QueryCompilationContext.QueryTrackingBehavior == QueryTrackingBehavior.NoTrackingWithIdentityResolution));
 
                 default:
-                    throw new NotImplementedException();
+                    throw new NotSupportedException(CoreStrings.UnhandledExpressionNode(shapedQueryExpression.QueryExpression));
             }
         }
     }

src/EFCore.Cosmos/Storage/Internal/CosmosClientWrapper.cs

@@ -763,7 +763,7 @@ public void Dispose()
                 }
 
                 public void Reset()
-                    => throw new NotImplementedException();
+                    => throw new NotSupportedException(CoreStrings.EnumerableResetNotSupported);
             }
         }
 

src/EFCore.Cosmos/Storage/Internal/CosmosDatabaseCreator.cs

@@ -5,6 +5,7 @@
 using System.Threading;
 using System.Threading.Tasks;
 using JetBrains.Annotations;
+using Microsoft.EntityFrameworkCore.Cosmos.Internal;
 using Microsoft.EntityFrameworkCore.Metadata;
 using Microsoft.EntityFrameworkCore.Storage;
 using Microsoft.EntityFrameworkCore.Update;
@@ -167,7 +168,7 @@ public virtual Task<bool> EnsureDeletedAsync(CancellationToken cancellationToken
         ///     doing so can result in application failures when updating to a new Entity Framework Core release.
         /// </summary>
         public virtual bool CanConnect()
-            => throw new NotImplementedException();
+            => throw new NotSupportedException(CosmosStrings.CanConnectNotSupported);
 
         /// <summary>
         ///     This is an internal API that supports the Entity Framework Core infrastructure and not subject to
@@ -176,7 +177,7 @@ public virtual bool CanConnect()
         ///     doing so can result in application failures when updating to a new Entity Framework Core release.
         /// </summary>
         public virtual Task<bool> CanConnectAsync(CancellationToken cancellationToken = default)
-            => throw new NotImplementedException();
+            => throw new NotSupportedException(CosmosStrings.CanConnectNotSupported);
 
         /// <summary>
         ///     Returns the store name of the property that is used to store the partition key.

src/EFCore.Cosmos/Storage/Internal/CosmosTransactionManager.cs

@@ -5,6 +5,7 @@
 using System.Threading;
 using System.Threading.Tasks;
 using System.Transactions;
+using Microsoft.EntityFrameworkCore.Cosmos.Internal;
 using Microsoft.EntityFrameworkCore.Storage;
 
 namespace Microsoft.EntityFrameworkCore.Cosmos.Storage.Internal
@@ -24,7 +25,7 @@ public class CosmosTransactionManager : IDbContextTransactionManager, ITransacti
         ///     doing so can result in application failures when updating to a new Entity Framework Core release.
         /// </summary>
         public virtual IDbContextTransaction BeginTransaction()
-            => throw new NotSupportedException();
+            => throw new NotSupportedException(CosmosStrings.TransactionsNotSupported);
 
         /// <summary>
         ///     This is an internal API that supports the Entity Framework Core infrastructure and not subject to
@@ -34,7 +35,7 @@ public virtual IDbContextTransaction BeginTransaction()
         /// </summary>
         public virtual Task<IDbContextTransaction> BeginTransactionAsync(
             CancellationToken cancellationToken = default)
-            => throw new NotSupportedException();
+            => throw new NotSupportedException(CosmosStrings.TransactionsNotSupported);
 
         /// <summary>
         ///     This is an internal API that supports the Entity Framework Core infrastructure and not subject to
@@ -43,7 +44,7 @@ public virtual Task<IDbContextTransaction> BeginTransactionAsync(
         ///     doing so can result in application failures when updating to a new Entity Framework Core release.
         /// </summary>
         public virtual void CommitTransaction()
-            => throw new NotSupportedException();
+            => throw new NotSupportedException(CosmosStrings.TransactionsNotSupported);
 
         /// <summary>
         ///     This is an internal API that supports the Entity Framework Core infrastructure and not subject to
@@ -52,7 +53,7 @@ public virtual void CommitTransaction()
         ///     doing so can result in application failures when updating to a new Entity Framework Core release.
         /// </summary>
         public virtual Task CommitTransactionAsync(CancellationToken cancellationToken = default)
-            => throw new NotSupportedException();
+            => throw new NotSupportedException(CosmosStrings.TransactionsNotSupported);
 
         /// <summary>
         ///     This is an internal API that supports the Entity Framework Core infrastructure and not subject to
@@ -61,7 +62,7 @@ public virtual Task CommitTransactionAsync(CancellationToken cancellationToken =
         ///     doing so can result in application failures when updating to a new Entity Framework Core release.
         /// </summary>
         public virtual void RollbackTransaction()
-            => throw new NotSupportedException();
+            => throw new NotSupportedException(CosmosStrings.TransactionsNotSupported);
 
         /// <summary>
         ///     This is an internal API that supports the Entity Framework Core infrastructure and not subject to
@@ -70,7 +71,7 @@ public virtual void RollbackTransaction()
         ///     doing so can result in application failures when updating to a new Entity Framework Core release.
         /// </summary>
         public virtual Task RollbackTransactionAsync(CancellationToken cancellationToken = default)
-            => throw new NotSupportedException();
+            => throw new NotSupportedException(CosmosStrings.TransactionsNotSupported);
 
         /// <summary>
         ///     This is an internal API that supports the Entity Framework Core infrastructure and not subject to
@@ -97,7 +98,7 @@ public virtual Transaction EnlistedTransaction
         ///     doing so can result in application failures when updating to a new Entity Framework Core release.
         /// </summary>
         public virtual void EnlistTransaction(Transaction transaction)
-            => throw new NotSupportedException();
+            => throw new NotSupportedException(CosmosStrings.TransactionsNotSupported);
 
         /// <summary>
         ///     This is an internal API that supports the Entity Framework Core infrastructure and not subject to

src/EFCore.InMemory/Query/Internal/InMemoryShapedQueryCompilingExpressionVisitor.QueryingEnumerable.cs

@@ -160,7 +160,7 @@ public ValueTask DisposeAsync()
                 }
 
                 public void Reset()
-                    => throw new NotImplementedException();
+                    => throw new NotSupportedException(CoreStrings.EnumerableResetNotSupported);
             }
         }
     }

src/EFCore.Relational/Extensions/RelationalEntityTypeExtensions.cs

@@ -787,7 +787,7 @@ public static IEnumerable<IForeignKey> FindRowInternalForeignKeys(
 
                         break;
                     default:
-                        throw new NotImplementedException(storeObject.StoreObjectType.ToString());
+                        throw new NotSupportedException(storeObject.StoreObjectType.ToString());
                 }
             }
         }

src/EFCore.Relational/Extensions/RelationalPropertyExtensions.cs

@@ -176,7 +176,7 @@ public static string GetDefaultColumnName([NotNull] this IProperty property, in
 
                         break;
                     default:
-                        throw new NotImplementedException(storeObject.StoreObjectType.ToString());
+                        throw new NotSupportedException(storeObject.StoreObjectType.ToString());
                 }
 
                 if (entityType == null)
@@ -456,7 +456,7 @@ public static IColumnBase FindColumn([NotNull] this IProperty property, in Store
 
                     return null;
                 default:
-                    throw new NotImplementedException(storeObject.StoreObjectType.ToString());
+                    throw new NotSupportedException(storeObject.StoreObjectType.ToString());
             }
         }
 

src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs

@@ -1253,7 +1253,7 @@ protected virtual void ValidatePropertyOverrides(
 
                                 break;
                             default:
-                                throw new NotImplementedException(storeOverride.StoreObjectType.ToString());
+                                throw new NotSupportedException(storeOverride.StoreObjectType.ToString());
                         }
                     }
                 }

src/EFCore.Relational/Metadata/Internal/RelationalModel.cs

@@ -1128,7 +1128,7 @@ public static ReferentialAction ToReferentialAction(DeleteBehavior deleteBehavio
                 case DeleteBehavior.ClientCascade:
                     return ReferentialAction.Restrict;
                 default:
-                    throw new NotImplementedException(deleteBehavior.ToString());
+                    throw new NotSupportedException(deleteBehavior.ToString());
             }
         }
 

src/EFCore.Relational/Migrations/Internal/MigrationsModelDiffer.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
@@ -874,7 +874,7 @@ public bool Equals(PropertyInfo x, PropertyInfo y)
                 => x.IsSameAs(y);
 
             public int GetHashCode(PropertyInfo obj)
-                => throw new NotImplementedException();
+                => throw new NotSupportedException();
         }
 
         #endregion

src/EFCore.Relational/Migrations/Migration.cs

@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using JetBrains.Annotations;
+using Microsoft.EntityFrameworkCore.Diagnostics;
 using Microsoft.EntityFrameworkCore.Metadata;
 using Microsoft.EntityFrameworkCore.Migrations.Operations;
 
@@ -118,9 +119,7 @@ protected virtual void BuildTargetModel([NotNull] ModelBuilder modelBuilder)
         /// </summary>
         /// <param name="migrationBuilder"> The <see cref="MigrationBuilder" /> that will build the operations. </param>
         protected virtual void Down([NotNull] MigrationBuilder migrationBuilder)
-        {
-            throw new NotImplementedException();
-        }
+            => throw new NotSupportedException(RelationalStrings.MigrationDownMissing);
 
         private List<MigrationOperation> BuildOperations(Action<MigrationBuilder> buildAction)
         {