Don't dispose current transaction when replaced with new one.

dotnet · Sep 14, 2021 · cedcb09 · cedcb09
1 parent a20b5f5
commit cedcb09
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 24 deletions.
diff --git a/src/EFCore.Relational/Storage/RelationalConnection.cs b/src/EFCore.Relational/Storage/RelationalConnection.cs
@@ -476,11 +476,6 @@ private IDbContextTransaction CreateRelationalTransaction(DbTransaction transact
         {
             if (ShouldUseTransaction(transaction))
             {
-                if (CurrentTransaction != null)
-                {
-                    CurrentTransaction.Dispose();
-                }
-
                 Open();
 
                 transaction = Dependencies.TransactionLogger.TransactionUsed(
@@ -522,11 +517,6 @@ private IDbContextTransaction CreateRelationalTransaction(DbTransaction transact
         {
             if (ShouldUseTransaction(transaction))
             {
-                if (CurrentTransaction != null)
-                {
-                    await CurrentTransaction.DisposeAsync();
-                }
-
                 await OpenAsync(cancellationToken).ConfigureAwait(false);
 
                 transaction = await Dependencies.TransactionLogger.TransactionUsedAsync(

diff --git a/test/EFCore.SqlServer.FunctionalTests/ExecutionStrategyTest.cs b/test/EFCore.SqlServer.FunctionalTests/ExecutionStrategyTest.cs
@@ -446,13 +446,6 @@ await c.AuditContext.Database.UseTransactionAsync(
 
                             Assert.NotSame(currentTransaction, c.AuditContext.Database.CurrentTransaction);
 
-                            if (currentTransaction != null)
-                            {
-                                Assert.True(
-                                    (bool)typeof(RelationalTransaction).GetRuntimeFields().Single(f => f.Name == "_disposed")
-                                        .GetValue(currentTransaction)!);
-                            }
-
                             await c.AuditContext.Audits.AddAsync(new Audit(), ct);
                             await c.AuditContext.SaveChangesAsync(ct);
 
@@ -497,13 +490,6 @@ await c.AuditContext.Database.UseTransactionAsync(
 
                             Assert.NotSame(currentTransaction, c.AuditContext.Database.CurrentTransaction);
 
-                            if (currentTransaction != null)
-                            {
-                                Assert.True(
-                                    (bool)typeof(RelationalTransaction).GetRuntimeFields().Single(f => f.Name == "_disposed")
-                                        .GetValue(currentTransaction)!);
-                            }
-
                             c.AuditContext.Audits.Add(new Audit());
                             c.AuditContext.SaveChanges();