RevEng: Decimal column with same precision and scale as the default produce warnings at runtime

[johanskoldekrans]

I have a sort of related "issue" to #6965.

If my column in the database is decimal(18,2) the scaffolding will not produce .HasColumnType("decimal(18, 2)") since I guess it is equal to the default.

BUT on the other hand I get frightening warnings when I run the project that no type was specified for the decimal column and that the values might be silently truncated.

It would be best if the scaffolding produced the HascolumnType even if it is equal to the current default so I dont get heartattacks from the warnings. :-)

Further technical details

EF Core version: 2.1
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Win10
IDE: Visual Studio 2017 15.7.3

[smitpatel]

Marking for re-triage. Currently decimal warning is in ModelValidator code. And the inference about requiring HasColumnType happens in ScaffoldingTypeMapper via TypeMappingSource. We don't have enough information available to do this in provider agnostic way right now.

[ajcvickers]

Triage: we will make a change to always scaffold a column type for decimal for all providers. This means there may be some extra configuration in the model that is not needed, but there will be no warnings at runtime. We will then leave this issue open to do a provider-specific fix once the infrastructure is in place.

[bricelam]

Reopening:

We will then leave this issue open to do a provider-specific fix once the infrastructure is in place.

[ErikEJ]

@bricelam Why is this still open?

[smitpatel]

We want to scaffold the decimal type only in SqlServer provider rather than everywhere. So providers have to contribute in certain way that, ClrType requires HasColumnType regardless of it being default.

[dengere]

@bricelam Why is this still open?

Reply from future; Why is this still open?

[ajcvickers]

@dengere Because the work to implement this hasn't been done.