Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-constant property name in EF.Property (and indexer property) #15832

Closed
roji opened this issue May 28, 2019 · 4 comments · Fixed by #24846
Closed

Non-constant property name in EF.Property (and indexer property) #15832

roji opened this issue May 28, 2019 · 4 comments · Fixed by #24846
Assignees
@maumar
Labels
area-query area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 punted-for-3.1 type-enhancement
Milestone
6.0.0

Comments

@roji
Copy link
Member

roji commented May 28, 2019

Investigate what is currently happening (and what we want to be happening) if a non-constant expression (e.g. closure parameter) is used for the property name to EF.Property() (and the indexer property).
@ajcvickers
Copy link
Member

ajcvickers commented May 31, 2019 •
edited
Loading

For 3.0, we should understand what is happening, and throw for non-constants if needed.

@ajcvickers ajcvickers added this to the 3.0.0 milestone May 31, 2019
@divega divega modified the milestones: 3.0.0, Backlog Jun 21, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 3.1.0 Sep 4, 2019
@ajcvickers ajcvickers modified the milestones: 3.1.0, Backlog Oct 11, 2019
@smitpatel
Copy link
Member

We are past 3.0 and we should just close this. We did not have any issues with it and indexer also has test to pass propertyname as variable and still get constant in the tree.

@roji
Copy link
Member Author

roji commented Mar 26, 2020

Sounds good to me...

@ajcvickers ajcvickers modified the milestones: Backlog, MQ Sep 11, 2020
@ajcvickers
Copy link
Member

@maumar to add a test.

@ajcvickers ajcvickers modified the milestones: MQ, 6.0.0 Dec 16, 2020
maumar added a commit that referenced this issue May 5, 2021
@maumar
Adding tests for #15832 - Non-constant property name in EF.Property (…
c22303f 
…and indexer property)

Resolves #15832
@maumar maumar mentioned this issue May 5, 2021
Merged
maumar added a commit that referenced this issue May 5, 2021
@maumar
Adding tests for #15832 - Non-constant property name in EF.Property (…
ed8d45e 
…and indexer property)

Resolves #15832
maumar added a commit that referenced this issue May 5, 2021
@maumar
Adding tests for #15832 - Non-constant property name in EF.Property (…
6915f5b 
…and indexer property)

Resolves #15832
maumar added a commit that referenced this issue May 6, 2021
@maumar
Adding tests for #15832 - Non-constant property name in EF.Property (…
78435ee 
…and indexer property)

Resolves #15832
maumar added a commit that referenced this issue May 6, 2021
@maumar
Adding tests for #15832 - Non-constant property name in EF.Property (…
5628c9d 
…and indexer property)

Resolves #15832
maumar added a commit that referenced this issue May 6, 2021
@maumar
Adding tests for #15832 - Non-constant property name in EF.Property (…
a6f773f 
…and indexer property)

Resolves #15832
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label May 6, 2021
maumar added a commit that referenced this issue Aug 4, 2021
@maumar
Adding tests for #15832 - Non-constant property name in EF.Property (…
da58068 
…and indexer property)

Resolves #15832
maumar added a commit that referenced this issue Aug 4, 2021
@maumar
Adding tests for #15832 - Non-constant property name in EF.Property (…
dbbe089 
…and indexer property)

Resolves #15832
@maumar maumar closed this as completed in 5464047 Aug 5, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-rc1 Aug 12, 2021
@ajcvickers ajcvickers mentioned this issue Sep 23, 2021
Closed
@ajcvickers ajcvickers modified the milestones: 6.0.0-rc1, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
area-query area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 punted-for-3.1 type-enhancement
Projects
None yet
Milestone
6.0.0
5 participants
@divega @ajcvickers @smitpatel @maumar @roji